Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: webrtc/pc/channel.cc

Issue 1697163002: Remove conference_mode flag from AudioOptions and VideoOptions. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix logic when SetSendParameters changes conference_mode but no options. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1780 matching lines...) Expand 10 before | Expand all | Expand 10 after
1791 } 1791 }
1792 1792
1793 1793
1794 if (!SetRtpTransportParameters_w(content, action, CS_REMOTE, error_desc)) { 1794 if (!SetRtpTransportParameters_w(content, action, CS_REMOTE, error_desc)) {
1795 return false; 1795 return false;
1796 } 1796 }
1797 1797
1798 VideoSendParameters send_params = last_send_params_; 1798 VideoSendParameters send_params = last_send_params_;
1799 RtpSendParametersFromMediaDescription(video, &send_params); 1799 RtpSendParametersFromMediaDescription(video, &send_params);
1800 if (video->conference_mode()) { 1800 if (video->conference_mode()) {
1801 send_params.options.conference_mode = rtc::Optional<bool>(true); 1801 send_params.conference_mode = true;
1802 } 1802 }
1803 if (!media_channel()->SetSendParameters(send_params)) { 1803 if (!media_channel()->SetSendParameters(send_params)) {
1804 SafeSetError("Failed to set remote video description send parameters.", 1804 SafeSetError("Failed to set remote video description send parameters.",
1805 error_desc); 1805 error_desc);
1806 return false; 1806 return false;
1807 } 1807 }
1808 last_send_params_ = send_params; 1808 last_send_params_ = send_params;
1809 1809
1810 // TODO(pthatcher): Move remote streams into VideoRecvParameters, 1810 // TODO(pthatcher): Move remote streams into VideoRecvParameters,
1811 // and only give it to the media channel once we have a local 1811 // and only give it to the media channel once we have a local
(...skipping 436 matching lines...) Expand 10 before | Expand all | Expand 10 after
2248 return (data_channel_type_ == DCT_RTP) && BaseChannel::ShouldSetupDtlsSrtp(); 2248 return (data_channel_type_ == DCT_RTP) && BaseChannel::ShouldSetupDtlsSrtp();
2249 } 2249 }
2250 2250
2251 void DataChannel::OnStreamClosedRemotely(uint32_t sid) { 2251 void DataChannel::OnStreamClosedRemotely(uint32_t sid) {
2252 rtc::TypedMessageData<uint32_t>* message = 2252 rtc::TypedMessageData<uint32_t>* message =
2253 new rtc::TypedMessageData<uint32_t>(sid); 2253 new rtc::TypedMessageData<uint32_t>(sid);
2254 signaling_thread()->Post(this, MSG_STREAMCLOSEDREMOTELY, message); 2254 signaling_thread()->Post(this, MSG_STREAMCLOSEDREMOTELY, message);
2255 } 2255 }
2256 2256
2257 } // namespace cricket 2257 } // namespace cricket
OLDNEW
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698