Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: webrtc/media/base/videoengine_unittest.h

Issue 1697163002: Remove conference_mode flag from AudioOptions and VideoOptions. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix logic when SetSendParameters changes conference_mode but no options. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/base/mediachannel.h ('k') | webrtc/media/engine/webrtcvideoengine2.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 476 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 EXPECT_TRUE(channel_->GetStats(&info)); 487 EXPECT_TRUE(channel_->GetStats(&info));
488 return info.receivers[i]; 488 return info.receivers[i];
489 } 489 }
490 490
491 // Test that stats work properly for a conf call with multiple recv streams. 491 // Test that stats work properly for a conf call with multiple recv streams.
492 void GetStatsMultipleRecvStreams() { 492 void GetStatsMultipleRecvStreams() {
493 cricket::FakeVideoRenderer renderer1, renderer2; 493 cricket::FakeVideoRenderer renderer1, renderer2;
494 EXPECT_TRUE(SetOneCodec(DefaultCodec())); 494 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
495 cricket::VideoSendParameters parameters; 495 cricket::VideoSendParameters parameters;
496 parameters.codecs.push_back(DefaultCodec()); 496 parameters.codecs.push_back(DefaultCodec());
497 parameters.options.conference_mode = rtc::Optional<bool>(true); 497 parameters.conference_mode = true;
498 EXPECT_TRUE(channel_->SetSendParameters(parameters)); 498 EXPECT_TRUE(channel_->SetSendParameters(parameters));
499 EXPECT_TRUE(SetSend(true)); 499 EXPECT_TRUE(SetSend(true));
500 EXPECT_TRUE(channel_->AddRecvStream( 500 EXPECT_TRUE(channel_->AddRecvStream(
501 cricket::StreamParams::CreateLegacy(1))); 501 cricket::StreamParams::CreateLegacy(1)));
502 EXPECT_TRUE(channel_->AddRecvStream( 502 EXPECT_TRUE(channel_->AddRecvStream(
503 cricket::StreamParams::CreateLegacy(2))); 503 cricket::StreamParams::CreateLegacy(2)));
504 EXPECT_TRUE(channel_->SetSink(1, &renderer1)); 504 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
505 EXPECT_TRUE(channel_->SetSink(2, &renderer2)); 505 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
506 EXPECT_EQ(0, renderer1.num_rendered_frames()); 506 EXPECT_EQ(0, renderer1.num_rendered_frames());
507 EXPECT_EQ(0, renderer2.num_rendered_frames()); 507 EXPECT_EQ(0, renderer2.num_rendered_frames());
(...skipping 30 matching lines...) Expand all
538 EXPECT_EQ(DefaultCodec().height, GetReceiverStats(i).frame_height); 538 EXPECT_EQ(DefaultCodec().height, GetReceiverStats(i).frame_height);
539 } 539 }
540 } 540 }
541 // Test that stats work properly for a conf call with multiple send streams. 541 // Test that stats work properly for a conf call with multiple send streams.
542 void GetStatsMultipleSendStreams() { 542 void GetStatsMultipleSendStreams() {
543 // Normal setup; note that we set the SSRC explicitly to ensure that 543 // Normal setup; note that we set the SSRC explicitly to ensure that
544 // it will come first in the senders map. 544 // it will come first in the senders map.
545 EXPECT_TRUE(SetOneCodec(DefaultCodec())); 545 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
546 cricket::VideoSendParameters parameters; 546 cricket::VideoSendParameters parameters;
547 parameters.codecs.push_back(DefaultCodec()); 547 parameters.codecs.push_back(DefaultCodec());
548 parameters.options.conference_mode = rtc::Optional<bool>(true); 548 parameters.conference_mode = true;
549 EXPECT_TRUE(channel_->SetSendParameters(parameters)); 549 EXPECT_TRUE(channel_->SetSendParameters(parameters));
550 EXPECT_TRUE(channel_->AddRecvStream( 550 EXPECT_TRUE(channel_->AddRecvStream(
551 cricket::StreamParams::CreateLegacy(kSsrc))); 551 cricket::StreamParams::CreateLegacy(kSsrc)));
552 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_)); 552 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
553 EXPECT_TRUE(SetSend(true)); 553 EXPECT_TRUE(SetSend(true));
554 EXPECT_TRUE(SendFrame()); 554 EXPECT_TRUE(SendFrame());
555 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout); 555 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
556 EXPECT_FRAME_WAIT(1, DefaultCodec().width, DefaultCodec().height, kTimeout); 556 EXPECT_FRAME_WAIT(1, DefaultCodec().width, DefaultCodec().height, kTimeout);
557 557
558 // Add an additional capturer, and hook up a renderer to receive it. 558 // Add an additional capturer, and hook up a renderer to receive it.
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
718 ParseRtpPacket(p.get(), NULL, NULL, NULL, NULL, &ssrc, NULL); 718 ParseRtpPacket(p.get(), NULL, NULL, NULL, NULL, &ssrc, NULL);
719 EXPECT_EQ(789u, ssrc); 719 EXPECT_EQ(789u, ssrc);
720 } 720 }
721 721
722 // Tests the behavior of incoming streams in a conference scenario. 722 // Tests the behavior of incoming streams in a conference scenario.
723 void SimulateConference() { 723 void SimulateConference() {
724 cricket::FakeVideoRenderer renderer1, renderer2; 724 cricket::FakeVideoRenderer renderer1, renderer2;
725 EXPECT_TRUE(SetDefaultCodec()); 725 EXPECT_TRUE(SetDefaultCodec());
726 cricket::VideoSendParameters parameters; 726 cricket::VideoSendParameters parameters;
727 parameters.codecs.push_back(DefaultCodec()); 727 parameters.codecs.push_back(DefaultCodec());
728 parameters.options.conference_mode = rtc::Optional<bool>(true); 728 parameters.conference_mode = true;
729 EXPECT_TRUE(channel_->SetSendParameters(parameters)); 729 EXPECT_TRUE(channel_->SetSendParameters(parameters));
730 EXPECT_TRUE(SetSend(true)); 730 EXPECT_TRUE(SetSend(true));
731 EXPECT_TRUE(channel_->AddRecvStream( 731 EXPECT_TRUE(channel_->AddRecvStream(
732 cricket::StreamParams::CreateLegacy(1))); 732 cricket::StreamParams::CreateLegacy(1)));
733 EXPECT_TRUE(channel_->AddRecvStream( 733 EXPECT_TRUE(channel_->AddRecvStream(
734 cricket::StreamParams::CreateLegacy(2))); 734 cricket::StreamParams::CreateLegacy(2)));
735 EXPECT_TRUE(channel_->SetSink(1, &renderer1)); 735 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
736 EXPECT_TRUE(channel_->SetSink(2, &renderer2)); 736 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
737 EXPECT_EQ(0, renderer1.num_rendered_frames()); 737 EXPECT_EQ(0, renderer1.num_rendered_frames());
738 EXPECT_EQ(0, renderer2.num_rendered_frames()); 738 EXPECT_EQ(0, renderer2.num_rendered_frames());
(...skipping 443 matching lines...) Expand 10 before | Expand all | Expand 10 after
1182 rtc::scoped_ptr<C> channel_; 1182 rtc::scoped_ptr<C> channel_;
1183 cricket::FakeNetworkInterface network_interface_; 1183 cricket::FakeNetworkInterface network_interface_;
1184 cricket::FakeVideoRenderer renderer_; 1184 cricket::FakeVideoRenderer renderer_;
1185 cricket::VideoMediaChannel::Error media_error_; 1185 cricket::VideoMediaChannel::Error media_error_;
1186 1186
1187 // Used by test cases where 2 streams are run on the same channel. 1187 // Used by test cases where 2 streams are run on the same channel.
1188 cricket::FakeVideoRenderer renderer2_; 1188 cricket::FakeVideoRenderer renderer2_;
1189 }; 1189 };
1190 1190
1191 #endif // WEBRTC_MEDIA_BASE_VIDEOENGINE_UNITTEST_H_ NOLINT 1191 #endif // WEBRTC_MEDIA_BASE_VIDEOENGINE_UNITTEST_H_ NOLINT
OLDNEW
« no previous file with comments | « webrtc/media/base/mediachannel.h ('k') | webrtc/media/engine/webrtcvideoengine2.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698