Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Side by Side Diff: webrtc/media/engine/webrtcvideoengine2_unittest.cc

Issue 1697163002: Remove conference_mode flag from AudioOptions and VideoOptions. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix logic when SetSendParameters changes conference_mode but no options. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2.cc ('k') | webrtc/pc/channel.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1051 matching lines...) Expand 10 before | Expand all | Expand 10 after
1062 EXPECT_EQ(kSyncLabel, 1062 EXPECT_EQ(kSyncLabel,
1063 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group) 1063 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
1064 << "SyncGroup should be set based on sync_label"; 1064 << "SyncGroup should be set based on sync_label";
1065 } 1065 }
1066 1066
1067 TEST_F(WebRtcVideoChannel2Test, RecvStreamWithSimAndRtx) { 1067 TEST_F(WebRtcVideoChannel2Test, RecvStreamWithSimAndRtx) {
1068 cricket::VideoSendParameters parameters; 1068 cricket::VideoSendParameters parameters;
1069 parameters.codecs = engine_.codecs(); 1069 parameters.codecs = engine_.codecs();
1070 EXPECT_TRUE(channel_->SetSendParameters(parameters)); 1070 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1071 EXPECT_TRUE(channel_->SetSend(true)); 1071 EXPECT_TRUE(channel_->SetSend(true));
1072 parameters.options.conference_mode = rtc::Optional<bool>(true); 1072 parameters.conference_mode = true;
1073 EXPECT_TRUE(channel_->SetSendParameters(parameters)); 1073 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1074 1074
1075 // Send side. 1075 // Send side.
1076 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1); 1076 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
1077 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1); 1077 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
1078 FakeVideoSendStream* send_stream = AddSendStream( 1078 FakeVideoSendStream* send_stream = AddSendStream(
1079 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)); 1079 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
1080 1080
1081 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size()); 1081 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
1082 for (size_t i = 0; i < rtx_ssrcs.size(); ++i) 1082 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
(...skipping 423 matching lines...) Expand 10 before | Expand all | Expand 10 after
1506 EXPECT_EQ(capture_format_hd.height, encoder_config.streams.front().height); 1506 EXPECT_EQ(capture_format_hd.height, encoder_config.streams.front().height);
1507 EXPECT_TRUE(encoder_config.streams[0].temporal_layer_thresholds_bps.empty()); 1507 EXPECT_TRUE(encoder_config.streams[0].temporal_layer_thresholds_bps.empty());
1508 1508
1509 EXPECT_TRUE(channel_->SetCapturer(last_ssrc_, NULL)); 1509 EXPECT_TRUE(channel_->SetCapturer(last_ssrc_, NULL));
1510 } 1510 }
1511 1511
1512 TEST_F(WebRtcVideoChannel2Test, 1512 TEST_F(WebRtcVideoChannel2Test,
1513 ConferenceModeScreencastConfiguresTemporalLayer) { 1513 ConferenceModeScreencastConfiguresTemporalLayer) {
1514 static const int kConferenceScreencastTemporalBitrateBps = 1514 static const int kConferenceScreencastTemporalBitrateBps =
1515 ScreenshareLayerConfig::GetDefault().tl0_bitrate_kbps * 1000; 1515 ScreenshareLayerConfig::GetDefault().tl0_bitrate_kbps * 1000;
1516 send_parameters_.options.conference_mode = rtc::Optional<bool>(true); 1516 send_parameters_.conference_mode = true;
1517 channel_->SetSendParameters(send_parameters_); 1517 channel_->SetSendParameters(send_parameters_);
1518 1518
1519 AddSendStream(); 1519 AddSendStream();
1520 1520
1521 cricket::FakeVideoCapturer capturer; 1521 cricket::FakeVideoCapturer capturer;
1522 capturer.SetScreencast(true); 1522 capturer.SetScreencast(true);
1523 EXPECT_TRUE(channel_->SetCapturer(last_ssrc_, &capturer)); 1523 EXPECT_TRUE(channel_->SetCapturer(last_ssrc_, &capturer));
1524 cricket::VideoFormat capture_format_hd = 1524 cricket::VideoFormat capture_format_hd =
1525 capturer.GetSupportedFormats()->front(); 1525 capturer.GetSupportedFormats()->front();
1526 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd)); 1526 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
(...skipping 1551 matching lines...) Expand 10 before | Expand all | Expand 10 after
3078 // Test that we normalize send codec format size in simulcast. 3078 // Test that we normalize send codec format size in simulcast.
3079 TEST_F(WebRtcVideoChannel2SimulcastTest, SetSendCodecsWithOddSizeInSimulcast) { 3079 TEST_F(WebRtcVideoChannel2SimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
3080 cricket::VideoCodec codec(kVp8Codec270p); 3080 cricket::VideoCodec codec(kVp8Codec270p);
3081 codec.width += 1; 3081 codec.width += 1;
3082 codec.height += 1; 3082 codec.height += 1;
3083 VerifySimulcastSettings(codec, 2, 2); 3083 VerifySimulcastSettings(codec, 2, 2);
3084 } 3084 }
3085 } // namespace cricket 3085 } // namespace cricket
3086 3086
3087 #endif // HAVE_WEBRTC_VIDEO 3087 #endif // HAVE_WEBRTC_VIDEO
OLDNEW
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2.cc ('k') | webrtc/pc/channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698