Clean up PlatformThread.

Clean up PlatformThread.

* Move PlatformThread to rtc::.
* Remove ::CreateThread factory method.
* Make non-scoped_ptr from a lot of invocations.
* Make Start/Stop void.
* Remove rtc::Thread priorities, which were unused and would collide.
* Add ::IsRunning() to PlatformThread.

BUG=
R=tommi@webrtc.org

Committed: https://crrev.com/8c38e8b9b96d72317d6ce94c1442113b4e385dcb
Cr-Commit-Position: refs/heads/master@{#10812}

[pbos-webrtc, 2015-11-24 11:57:41]

Description was changed from

==========
Clean up PlatformThread.

* Move PlatformThread to rtc::.
* Remove ::CreateThread factory method.
* Make non-scoped_ptr from a lot of invocations.
* Make Start/Stop void.

BUG=
R=tommi@webrtc.org
==========

to

==========
Clean up PlatformThread.

* Move PlatformThread to rtc::.
* Remove ::CreateThread factory method.
* Make non-scoped_ptr from a lot of invocations.
* Make Start/Stop void.
* Remove rtc::Thread priorities, which were unused and would collide.

BUG=
R=tommi@webrtc.org
==========

[pbos-webrtc, 2015-11-24 12:13:23]

add ::IsRunning() const

[pbos-webrtc, 2015-11-24 12:18:39]

rebase

[pbos-webrtc, 2015-11-24 12:19:08]

Patchset #3 (id:40001) has been deleted

[pbos-webrtc, 2015-11-26 12:52:26]

rebase

[pbos-webrtc, 2015-11-26 12:58:35]

platform compile failures + minor thread cleanup

[pbos-webrtc, 2015-11-26 13:01:31]

Description was changed from

==========
Clean up PlatformThread.

* Move PlatformThread to rtc::.
* Remove ::CreateThread factory method.
* Make non-scoped_ptr from a lot of invocations.
* Make Start/Stop void.
* Remove rtc::Thread priorities, which were unused and would collide.

BUG=
R=tommi@webrtc.org
==========

to

==========
Clean up PlatformThread.

* Move PlatformThread to rtc::.
* Remove ::CreateThread factory method.
* Make non-scoped_ptr from a lot of invocations.
* Make Start/Stop void.
* Remove rtc::Thread priorities, which were unused and would collide.
* Add ::IsRunning() to PlatformThread.

BUG=
R=tommi@webrtc.org
==========

[pbos-webrtc, 2015-11-26 13:06:06]

more windows compile errors

[pbos-webrtc, 2015-11-26 13:32:03]

!= FALSE and more win compile failures

[pbos-webrtc, 2015-11-26 13:35:40]

remove cpumonitor_unittest which is never built (and cpumonitor is long gone)

[pbos-webrtc, 2015-11-26 14:01:03]

hopefully the last win compile error

[pbos-webrtc, 2015-11-26 14:15:21]

Looks green now, PTAL tommi@! :)

[pbos-webrtc, 2015-11-26 14:15:30]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-26 14:15:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1476453002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1476453002/160001

[commit-bot: I haz the power, 2015-11-26 16:16:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-26 16:16:14]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[tommi, 2015-11-26 16:26:46]

lgtm. Great cleanup!  So much clutter removed.

https://codereview.webrtc.org/1476453002/diff/160001/webrtc/base/platform_thr...
File webrtc/base/platform_thread.cc (right):

https://codereview.webrtc.org/1476453002/diff/160001/webrtc/base/platform_thr...
webrtc/base/platform_thread.cc:198: if (!IsRunning())
nit: this isn't needed.  E.g. SetThreadPriority handles it and sets the
appropriate 'last error' value, which is better than this handling. 
pthread_setschedparam must do something similar.  For cases where we don't have
an implementation and just return true, we can return IsRunning() instead.

[pbos-webrtc, 2015-11-26 16:43:03]

https://codereview.webrtc.org/1476453002/diff/160001/webrtc/base/platform_thr...
File webrtc/base/platform_thread.cc (right):

https://codereview.webrtc.org/1476453002/diff/160001/webrtc/base/platform_thr...
webrtc/base/platform_thread.cc:198: if (!IsRunning())
On 2015/11/26 16:26:45, tommi (webrtc) wrote:
> nit: this isn't needed.  E.g. SetThreadPriority handles it and sets the
> appropriate 'last error' value, which is better than this handling. 
> pthread_setschedparam must do something similar.  For cases where we don't
have
> an implementation and just return true, we can return IsRunning() instead.

Turned into a DCHECK. All compiling code uses Start() just before which cannot
fail.

[pbos-webrtc, 2015-11-26 16:43:31]

IsRunning DCHECK

[pbos-webrtc, 2015-11-26 16:46:02]

Description was changed from

==========
Clean up PlatformThread.

* Move PlatformThread to rtc::.
* Remove ::CreateThread factory method.
* Make non-scoped_ptr from a lot of invocations.
* Make Start/Stop void.
* Remove rtc::Thread priorities, which were unused and would collide.
* Add ::IsRunning() to PlatformThread.

BUG=
R=tommi@webrtc.org
==========

to

==========
Clean up PlatformThread.

* Move PlatformThread to rtc::.
* Remove ::CreateThread factory method.
* Make non-scoped_ptr from a lot of invocations.
* Make Start/Stop void.
* Remove rtc::Thread priorities, which were unused and would collide.
* Add ::IsRunning() to PlatformThread.

BUG=
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/8c38e8b9b96d72317d6ce94c1...
==========

[pbos-webrtc, 2015-11-26 16:46:04]

Committed patchset #9 (id:170001) manually as
8c38e8b9b96d72317d6ce94c1442113b4e385dcb (presubmit successful).

[commit-bot: I haz the power, 2015-11-26 16:46:04]

Description was changed from

==========
Clean up PlatformThread.

* Move PlatformThread to rtc::.
* Remove ::CreateThread factory method.
* Make non-scoped_ptr from a lot of invocations.
* Make Start/Stop void.
* Remove rtc::Thread priorities, which were unused and would collide.
* Add ::IsRunning() to PlatformThread.

BUG=
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/8c38e8b9b96d72317d6ce94c1...
==========

to

==========
Clean up PlatformThread.

* Move PlatformThread to rtc::.
* Remove ::CreateThread factory method.
* Make non-scoped_ptr from a lot of invocations.
* Make Start/Stop void.
* Remove rtc::Thread priorities, which were unused and would collide.
* Add ::IsRunning() to PlatformThread.

BUG=
R=tommi@webrtc.org

Committed: https://crrev.com/8c38e8b9b96d72317d6ce94c1442113b4e385dcb
Cr-Commit-Position: refs/heads/master@{#10812}
==========

[commit-bot: I haz the power, 2015-11-26 16:46:05]

Patchset 9 (id:??) landed as
https://crrev.com/8c38e8b9b96d72317d6ce94c1442113b4e385dcb
Cr-Commit-Position: refs/heads/master@{#10812}