Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: webrtc/modules/utility/source/process_thread_impl.h

Issue 1476453002: Clean up PlatformThread. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: IsRunning DCHECK Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 // Warning: For some reason, if |lock_| comes immediately before |modules_| 63 // Warning: For some reason, if |lock_| comes immediately before |modules_|
64 // with the current class layout, we will start to have mysterious crashes 64 // with the current class layout, we will start to have mysterious crashes
65 // on Mac 10.9 debug. I (Tommi) suspect we're hitting some obscure alignemnt 65 // on Mac 10.9 debug. I (Tommi) suspect we're hitting some obscure alignemnt
66 // issues, but I haven't figured out what they are, if there are alignment 66 // issues, but I haven't figured out what they are, if there are alignment
67 // requirements for mutexes on Mac or if there's something else to it. 67 // requirements for mutexes on Mac or if there's something else to it.
68 // So be careful with changing the layout. 68 // So be careful with changing the layout.
69 rtc::CriticalSection lock_; // Used to guard modules_, tasks_ and stop_. 69 rtc::CriticalSection lock_; // Used to guard modules_, tasks_ and stop_.
70 70
71 rtc::ThreadChecker thread_checker_; 71 rtc::ThreadChecker thread_checker_;
72 const rtc::scoped_ptr<EventWrapper> wake_up_; 72 const rtc::scoped_ptr<EventWrapper> wake_up_;
73 rtc::scoped_ptr<PlatformThread> thread_; 73 // TODO(pbos): Remove scoped_ptr and stop recreating the thread.
74 rtc::scoped_ptr<rtc::PlatformThread> thread_;
74 75
75 ModuleList modules_; 76 ModuleList modules_;
76 // TODO(tommi): Support delayed tasks. 77 // TODO(tommi): Support delayed tasks.
77 std::queue<ProcessTask*> queue_; 78 std::queue<ProcessTask*> queue_;
78 bool stop_; 79 bool stop_;
79 const char* thread_name_; 80 const char* thread_name_;
80 }; 81 };
81 82
82 } // namespace webrtc 83 } // namespace webrtc
83 84
84 #endif // WEBRTC_MODULES_UTILITY_SOURCE_PROCESS_THREAD_IMPL_H_ 85 #endif // WEBRTC_MODULES_UTILITY_SOURCE_PROCESS_THREAD_IMPL_H_
OLDNEW
« no previous file with comments | « webrtc/modules/rtp_rtcp/test/BWEStandAlone/TestSenderReceiver.cc ('k') | webrtc/modules/utility/source/process_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698