webrtc/modules/audio_device/linux/audio_device_alsa_linux.h - Issue 1476453002: Clean up PlatformThread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_device/linux/audio_device_alsa_linux.h

Issue 1476453002: Clean up PlatformThread. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: IsRunning DCHECK Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_device/linux/audio_device_alsa_linux.h

diff --git a/webrtc/modules/audio_device/linux/audio_device_alsa_linux.h b/webrtc/modules/audio_device/linux/audio_device_alsa_linux.h

index c61dc86b5a030f0c1ce15749853fcdb9582a26ba..4a1a5191be907c6c5c337b687208ba26e9ea40de 100644

--- a/webrtc/modules/audio_device/linux/audio_device_alsa_linux.h

+++ b/webrtc/modules/audio_device/linux/audio_device_alsa_linux.h

@@ -185,8 +185,10 @@ private:

CriticalSectionWrapper& _critSect;

- rtc::scoped_ptr<PlatformThread> _ptrThreadRec;

- rtc::scoped_ptr<PlatformThread> _ptrThreadPlay;

+ // TODO(pbos): Make plain members and start/stop instead of resetting these

+ // pointers. A thread can be reused.

+ rtc::scoped_ptr<rtc::PlatformThread> _ptrThreadRec;

+ rtc::scoped_ptr<rtc::PlatformThread> _ptrThreadPlay;

int32_t _id;