Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Side by Side Diff: webrtc/base/platform_thread_unittest.cc

Issue 1476453002: Clean up PlatformThread. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: IsRunning DCHECK Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/platform_thread.cc ('k') | webrtc/base/signalthread.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/base/platform_thread.h" 11 #include "webrtc/base/platform_thread.h"
12 12
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 #include "webrtc/base/scoped_ptr.h" 14 #include "webrtc/base/scoped_ptr.h"
15 #include "webrtc/system_wrappers/include/sleep.h" 15 #include "webrtc/system_wrappers/include/sleep.h"
16 16
17 namespace webrtc { 17 namespace webrtc {
18 18
19 // Function that does nothing, and reports success. 19 // Function that does nothing, and reports success.
20 bool NullRunFunction(void* obj) { 20 bool NullRunFunction(void* obj) {
21 SleepMs(0); // Hand over timeslice, prevents busy looping. 21 SleepMs(0); // Hand over timeslice, prevents busy looping.
22 return true; 22 return true;
23 } 23 }
24 24
25 TEST(PlatformThreadTest, StartStop) { 25 TEST(PlatformThreadTest, StartStop) {
26 rtc::scoped_ptr<PlatformThread> thread = PlatformThread::CreateThread( 26 rtc::PlatformThread thread(&NullRunFunction, nullptr, "PlatformThreadTest");
27 &NullRunFunction, nullptr, "PlatformThreadTest"); 27 thread.Start();
28 ASSERT_TRUE(thread->Start()); 28 thread.Stop();
29 EXPECT_TRUE(thread->Stop());
30 } 29 }
31 30
32 // Function that sets a boolean. 31 // Function that sets a boolean.
33 bool SetFlagRunFunction(void* obj) { 32 bool SetFlagRunFunction(void* obj) {
34 bool* obj_as_bool = static_cast<bool*>(obj); 33 bool* obj_as_bool = static_cast<bool*>(obj);
35 *obj_as_bool = true; 34 *obj_as_bool = true;
36 SleepMs(0); // Hand over timeslice, prevents busy looping. 35 SleepMs(0); // Hand over timeslice, prevents busy looping.
37 return true; 36 return true;
38 } 37 }
39 38
40 TEST(PlatformThreadTest, RunFunctionIsCalled) { 39 TEST(PlatformThreadTest, RunFunctionIsCalled) {
41 bool flag = false; 40 bool flag = false;
42 rtc::scoped_ptr<PlatformThread> thread = PlatformThread::CreateThread( 41 rtc::PlatformThread thread(&SetFlagRunFunction, &flag, "RunFunctionIsCalled");
43 &SetFlagRunFunction, &flag, "RunFunctionIsCalled"); 42 thread.Start();
44 ASSERT_TRUE(thread->Start());
45 43
46 // At this point, the flag may be either true or false. 44 // At this point, the flag may be either true or false.
47 EXPECT_TRUE(thread->Stop()); 45 thread.Stop();
48 46
49 // We expect the thread to have run at least once. 47 // We expect the thread to have run at least once.
50 EXPECT_TRUE(flag); 48 EXPECT_TRUE(flag);
51 } 49 }
52 50
53 } // namespace webrtc 51 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/base/platform_thread.cc ('k') | webrtc/base/signalthread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698