Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1460043002: Don't call the Pass methods of rtc::Buffer, rtc::scoped_ptr, and rtc::ScopedVector (Closed)

Created:
5 years, 1 month ago by kwiberg-webrtc
Modified:
5 years ago
Reviewers:
tommi, pthatcher1
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), kwiberg-webrtc, stefan-webrtc, Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, mflodman, peah-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't call the Pass methods of rtc::Buffer, rtc::scoped_ptr, and rtc::ScopedVector We can now use std::move instead! This CL leaves the Pass methods in place; a follow-up CL will add deprecation annotations to them. Committed: https://crrev.com/0eb15ed7b806125774bd13fb214aeb403e2c6857 Cr-Commit-Position: refs/heads/master@{#11064}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase + remove a few new calls to .Pass() #

Patch Set 4 : rebase + remove a handful of new Pass calls #

Patch Set 5 : Restore the Pass methods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -203 lines) Patch
M talk/app/webrtc/dtlsidentitystore.h View 2 chunks +2 lines, -1 line 0 comments Download
M talk/app/webrtc/dtlsidentitystore.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M talk/app/webrtc/java/jni/peerconnection_jni.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnection.cc View 1 2 3 4 chunks +6 lines, -5 lines 0 comments Download
M talk/app/webrtc/peerconnection_unittest.cc View 1 2 3 6 chunks +8 lines, -5 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactory.cc View 1 2 3 2 chunks +4 lines, -6 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactory_unittest.cc View 9 chunks +24 lines, -38 lines 0 comments Download
M talk/app/webrtc/peerconnectionfactoryproxy.h View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M talk/app/webrtc/statscollector_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M talk/app/webrtc/test/fakedtlsidentitystore.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M talk/app/webrtc/test/peerconnectiontestwrapper.cc View 2 chunks +3 lines, -1 line 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M talk/app/webrtc/webrtcsession_unittest.cc View 1 2 3 5 chunks +7 lines, -6 lines 0 comments Download
M talk/app/webrtc/webrtcsessiondescriptionfactory.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M talk/session/media/channel.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M talk/session/media/channel_unittest.cc View 1 2 3 1 chunk +6 lines, -8 lines 0 comments Download
M talk/session/media/mediasession_unittest.cc View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/base/buffer.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/base/buffer.cc View 2 chunks +4 lines, -1 line 0 comments Download
M webrtc/base/messagehandler.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/base/rtccertificate_unittests.cc View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/base/scoped_ptr.h View 1 2 3 4 1 chunk +14 lines, -30 lines 0 comments Download
M webrtc/common_audio/audio_converter.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/rent_a_codec.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/android/audio_manager.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_record_jni.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_track_jni.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/test/audio_file_processor.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/test/audioproc_float.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/test/test_utils.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_win.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/bye_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/extended_jitter_report_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/source/process_thread_impl.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/utility/source/process_thread_impl_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/jitter_buffer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/receiver.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/p2p/base/transportcontroller_unittest.cc View 1 chunk +4 lines, -8 lines 0 comments Download
M webrtc/p2p/base/transportdescriptionfactory_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
kwiberg-webrtc
Please have a look: tommi: webrtc/ pthatcher: talk/ (Before this lands, https://codereview.chromium.org/1461173002/ needs to land ...
5 years, 1 month ago (2015-11-19 23:28:40 UTC) #3
tommi
lgtm
5 years ago (2015-12-07 20:12:08 UTC) #4
pthatcher1
lgtm
5 years ago (2015-12-08 20:10:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1460043002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1460043002/100001
5 years ago (2015-12-17 10:18:48 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years ago (2015-12-17 11:04:20 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-17 11:04:37 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0eb15ed7b806125774bd13fb214aeb403e2c6857
Cr-Commit-Position: refs/heads/master@{#11064}

Powered by Google App Engine
This is Rietveld 408576698