Slap deprecation notices on Pass methods

Slap deprecation notices on Pass methods

There's no reason not to use std::move instead now that we can use the
C++11 standard library.

BUG=webrtc:5373
Committed: https://crrev.com/36220ae24f8f5d34b660d6c4c91dd4260886dcb9
Cr-Commit-Position: refs/heads/master@{#11225}

[kwiberg-webrtc, 2015-12-17 10:33:20]

Description was changed from

==========
Slap deprecation notices on Pass methods

There's no reason not to use std::move instead now that we can use the
C++11 standard library.
==========

to

==========
Slap deprecation notices on Pass methods

There's no reason not to use std::move instead now that we can use the
C++11 standard library.
==========

[kwiberg-webrtc, 2015-12-17 10:33:20]

kwiberg@webrtc.org changed reviewers:
+ kjellander@webrtc.org, tommi@webrtc.org

[kjellander_webrtc, 2015-12-17 11:02:40]

Don't forget to set a calendar reminder in your calendar for March 2016 :)

https://codereview.webrtc.org/1531013003/diff/1/webrtc/base/buffer.h
File webrtc/base/buffer.h (right):

https://codereview.webrtc.org/1531013003/diff/1/webrtc/base/buffer.h#newcode175
webrtc/base/buffer.h:175: // Deprecated; the plan is to remove this method in
March 2016.
Maybe we should have a convention like "TODO(DEPRECATED):" to use here, to make
it easy to grep for them?

Even better would be to file a tracking bug and reference it here. Then others
can express opinions and discuss the deprecation.

[kwiberg-webrtc, 2015-12-17 11:44:30]

Description was changed from

==========
Slap deprecation notices on Pass methods

There's no reason not to use std::move instead now that we can use the
C++11 standard library.
==========

to

==========
Slap deprecation notices on Pass methods

There's no reason not to use std::move instead now that we can use the
C++11 standard library.

BUG=webrtc:5373
==========

[kwiberg-webrtc, 2015-12-17 11:49:56]

On 2015/12/17 11:02:40, kjellander (webrtc) wrote:
> Don't forget to set a calendar reminder in your calendar for March 2016 :)

Done!

> Even better would be to file a tracking bug and reference it here. Then others
> can express opinions and discuss the deprecation.

Done.

[kjellander_webrtc, 2015-12-18 20:38:56]

lgtm

[tommi, 2016-01-12 11:44:29]

lgtm. sorry for the delay, this fell off my radar.

[kwiberg-webrtc, 2016-01-12 13:43:51]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2016-01-12 13:43:52]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1531013003/#ps40001 (title:
"rebase")

[commit-bot: I haz the power, 2016-01-12 13:43:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531013003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531013003/40001

[commit-bot: I haz the power, 2016-01-12 15:24:23]

Description was changed from

==========
Slap deprecation notices on Pass methods

There's no reason not to use std::move instead now that we can use the
C++11 standard library.

BUG=webrtc:5373
==========

to

==========
Slap deprecation notices on Pass methods

There's no reason not to use std::move instead now that we can use the
C++11 standard library.

BUG=webrtc:5373
==========

[commit-bot: I haz the power, 2016-01-12 15:24:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-12 15:24:32]

Description was changed from

==========
Slap deprecation notices on Pass methods

There's no reason not to use std::move instead now that we can use the
C++11 standard library.

BUG=webrtc:5373
==========

to

==========
Slap deprecation notices on Pass methods

There's no reason not to use std::move instead now that we can use the
C++11 standard library.

BUG=webrtc:5373

Committed: https://crrev.com/36220ae24f8f5d34b660d6c4c91dd4260886dcb9
Cr-Commit-Position: refs/heads/master@{#11225}
==========

[commit-bot: I haz the power, 2016-01-12 15:24:33]

Patchset 3 (id:??) landed as
https://crrev.com/36220ae24f8f5d34b660d6c4c91dd4260886dcb9
Cr-Commit-Position: refs/heads/master@{#11225}