webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc - Issue 1460043002: Don't call the Pass methods of rtc::Buffer, rtc::scoped_ptr, and rtc::ScopedVector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc

Issue 1460043002: Don't call the Pass methods of rtc::Buffer, rtc::scoped_ptr, and rtc::ScopedVector (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Restore the Pass methods Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.cc ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/bye_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc

index 01ded72d9994c5dd01078d344df4f8e2ab61ba92..4451fe8fb51ddcdd08b3a1f64f1c6c262254a149 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/app_unittest.cc

@@ -29,7 +29,7 @@ const uint32_t kSenderSsrc = 0x12345678;

class RtcpPacketAppTest : public ::testing::Test {

protected:

- void BuildPacket() { packet = app.Build().Pass(); }

+ void BuildPacket() { packet = app.Build(); }

void ParsePacket() {

RtcpCommonHeader header;

EXPECT_TRUE(