Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: talk/app/webrtc/statscollector_unittest.cc

Issue 1460043002: Don't call the Pass methods of rtc::Buffer, rtc::scoped_ptr, and rtc::ScopedVector (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Restore the Pass methods Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2014 Google Inc. 3 * Copyright 2014 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 678 matching lines...) Expand 10 before | Expand all | Expand 10 after
689 transport_stats.transport_name = "audio"; 689 transport_stats.transport_name = "audio";
690 transport_stats.channel_stats.push_back(channel_stats); 690 transport_stats.channel_stats.push_back(channel_stats);
691 691
692 SessionStats session_stats; 692 SessionStats session_stats;
693 session_stats.transport_stats[transport_stats.transport_name] = 693 session_stats.transport_stats[transport_stats.transport_name] =
694 transport_stats; 694 transport_stats;
695 695
696 // Fake certificate to report 696 // Fake certificate to report
697 rtc::scoped_refptr<rtc::RTCCertificate> local_certificate( 697 rtc::scoped_refptr<rtc::RTCCertificate> local_certificate(
698 rtc::RTCCertificate::Create(rtc::scoped_ptr<rtc::FakeSSLIdentity>( 698 rtc::RTCCertificate::Create(rtc::scoped_ptr<rtc::FakeSSLIdentity>(
699 new rtc::FakeSSLIdentity(local_cert)) 699 new rtc::FakeSSLIdentity(local_cert))));
700 .Pass()));
701 700
702 // Configure MockWebRtcSession 701 // Configure MockWebRtcSession
703 EXPECT_CALL(session_, 702 EXPECT_CALL(session_,
704 GetLocalCertificate(transport_stats.transport_name, _)) 703 GetLocalCertificate(transport_stats.transport_name, _))
705 .WillOnce(DoAll(SetArgPointee<1>(local_certificate), Return(true))); 704 .WillOnce(DoAll(SetArgPointee<1>(local_certificate), Return(true)));
706 EXPECT_CALL(session_, 705 EXPECT_CALL(session_,
707 GetRemoteSSLCertificate(transport_stats.transport_name, _)) 706 GetRemoteSSLCertificate(transport_stats.transport_name, _))
708 .WillOnce( 707 .WillOnce(
709 DoAll(SetArgPointee<1>(remote_cert.GetReference()), Return(true))); 708 DoAll(SetArgPointee<1>(remote_cert.GetReference()), Return(true)));
710 EXPECT_CALL(session_, GetTransportStats(_)) 709 EXPECT_CALL(session_, GetTransportStats(_))
(...skipping 1029 matching lines...) Expand 10 before | Expand all | Expand 10 after
1740 cricket::VoiceSenderInfo new_voice_sender_info; 1739 cricket::VoiceSenderInfo new_voice_sender_info;
1741 InitVoiceSenderInfo(&new_voice_sender_info); 1740 InitVoiceSenderInfo(&new_voice_sender_info);
1742 cricket::VoiceMediaInfo new_stats_read; 1741 cricket::VoiceMediaInfo new_stats_read;
1743 reports.clear(); 1742 reports.clear();
1744 SetupAndVerifyAudioTrackStats( 1743 SetupAndVerifyAudioTrackStats(
1745 new_audio_track.get(), stream_.get(), &stats, &voice_channel, kVcName, 1744 new_audio_track.get(), stream_.get(), &stats, &voice_channel, kVcName,
1746 media_channel, &new_voice_sender_info, NULL, &new_stats_read, &reports); 1745 media_channel, &new_voice_sender_info, NULL, &new_stats_read, &reports);
1747 } 1746 }
1748 1747
1749 } // namespace webrtc 1748 } // namespace webrtc
OLDNEW
« no previous file with comments | « talk/app/webrtc/peerconnectioninterface_unittest.cc ('k') | talk/app/webrtc/test/fakedtlsidentitystore.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698