talk/session/media/mediasession_unittest.cc - Issue 1460043002: Don't call the Pass methods of rtc::Buffer, rtc::scoped_ptr, and rtc::ScopedVector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/session/media/mediasession_unittest.cc

Issue 1460043002: Don't call the Pass methods of rtc::Buffer, rtc::scoped_ptr, and rtc::ScopedVector (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Restore the Pass methods Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: talk/session/media/mediasession_unittest.cc

diff --git a/talk/session/media/mediasession_unittest.cc b/talk/session/media/mediasession_unittest.cc

index abb03e7de7049f7c707f4b74cc0ff91ed8f8b27b..20b72e93946393e9c2f7aa9886999583c9f3cbf3 100644

--- a/talk/session/media/mediasession_unittest.cc

+++ b/talk/session/media/mediasession_unittest.cc

@@ -238,11 +238,9 @@ class MediaSessionDescriptionFactoryTest : public testing::Test {

f2_.set_video_codecs(MAKE_VECTOR(kVideoCodecs2));

f2_.set_data_codecs(MAKE_VECTOR(kDataCodecs2));

tdf1_.set_certificate(rtc::RTCCertificate::Create(

- rtc::scoped_ptr<rtc::SSLIdentity>(

- new rtc::FakeSSLIdentity("id1")).Pass()));

+ rtc::scoped_ptr<rtc::SSLIdentity>(new rtc::FakeSSLIdentity("id1"))));

tdf2_.set_certificate(rtc::RTCCertificate::Create(

- rtc::scoped_ptr<rtc::SSLIdentity>(

- new rtc::FakeSSLIdentity("id2")).Pass()));

+ rtc::scoped_ptr<rtc::SSLIdentity>(new rtc::FakeSSLIdentity("id2"))));

}

// Create a video StreamParamsVec object with:

« no previous file with comments | « talk/session/media/channel_unittest.cc ('k') | webrtc/base/buffer.h » ('j') | no next file with comments »