Remove voe::OutputMixer and AudioConferenceMixer.

Remove voe::OutputMixer and AudioConferenceMixer.

This code path is not used anymore.

BUG=webrtc:4690
Review-Url: https://codereview.webrtc.org/3015553002
Cr-Commit-Position: refs/heads/master@{#19929}
Committed: https://webrtc.googlesource.com/src/+/2397b9a1149ebd84e2007bea7f7bfdab88b473c6

[the sun, 2017-09-18 14:40:05]

solenberg@webrtc.org changed reviewers:
+ aleloi@webrtc.org, henrik.lundin@webrtc.org

[the sun, 2017-09-18 14:40:31]

Description was changed from

==========
Remove voe::OutputMixer and AudioConferenceMixer.

BUG=webrtc:4690
==========

to

==========
Remove voe::OutputMixer and AudioConferenceMixer.

This code path is not used anymore.

BUG=webrtc:4690
==========

[the sun, 2017-09-18 14:41:13]

solenberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[the sun, 2017-09-18 14:41:26]

On 2017/09/18 14:40:05, the sun wrote:

+Karl for test/

[kwiberg-webrtc, 2017-09-18 17:43:41]

lgtm for test/

[the sun, 2017-09-21 07:45:11]

On 2017/09/18 17:43:41, kwiberg-webrtc wrote:
> lgtm for test/

Ping Alex, Henrik...

[aleloi, 2017-09-22 08:42:41]

lgtm!

[hlundin-webrtc, 2017-09-22 09:17:45]

LGTM with a few questions.

https://codereview.webrtc.org/3015553002/diff/60001/voice_engine/channel.cc
File voice_engine/channel.cc (right):

https://codereview.webrtc.org/3015553002/diff/60001/voice_engine/channel.cc#n...
voice_engine/channel.cc:650: audio_frame->id_ = VoEChannelId(audio_frame->id_);
Out of curiosity: is this ID ever used for anything? I have a sneaky feeling we
can delete it from AudioFrame (in a separate CL).

https://codereview.webrtc.org/3015553002/diff/60001/voice_engine/voe_base_imp...
File voice_engine/voe_base_impl.cc (right):

https://codereview.webrtc.org/3015553002/diff/60001/voice_engine/voe_base_imp...
voice_engine/voe_base_impl.cc:140: int32_t VoEBaseImpl::NeedMorePlayData(const
size_t nSamples,
Mark as deprecated?

https://codereview.webrtc.org/3015553002/diff/60001/voice_engine/voe_base_imp...
voice_engine/voe_base_impl.cc:169: void VoEBaseImpl::PullRenderData(int
bits_per_sample,
Mark as deprecated?

[the sun, 2017-09-22 10:49:00]

https://codereview.webrtc.org/3015553002/diff/60001/voice_engine/channel.cc
File voice_engine/channel.cc (right):

https://codereview.webrtc.org/3015553002/diff/60001/voice_engine/channel.cc#n...
voice_engine/channel.cc:650: audio_frame->id_ = VoEChannelId(audio_frame->id_);
On 2017/09/22 09:17:44, hlundin-webrtc wrote:
> Out of curiosity: is this ID ever used for anything? I have a sneaky feeling
we
> can delete it from AudioFrame (in a separate CL).

I think you're right about that.

https://codereview.webrtc.org/3015553002/diff/60001/voice_engine/voe_base_imp...
File voice_engine/voe_base_impl.cc (right):

https://codereview.webrtc.org/3015553002/diff/60001/voice_engine/voe_base_imp...
voice_engine/voe_base_impl.cc:140: int32_t VoEBaseImpl::NeedMorePlayData(const
size_t nSamples,
On 2017/09/22 09:17:44, hlundin-webrtc wrote:
> Mark as deprecated?

Done.

https://codereview.webrtc.org/3015553002/diff/60001/voice_engine/voe_base_imp...
voice_engine/voe_base_impl.cc:169: void VoEBaseImpl::PullRenderData(int
bits_per_sample,
On 2017/09/22 09:17:45, hlundin-webrtc wrote:
> Mark as deprecated?

Done.

[the sun, 2017-09-22 11:53:40]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2017-09-22 11:53:41]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org,
henrik.lundin@webrtc.org, aleloi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3015553002/#ps80001 (title:
"mark functions deprecated")

[commit-bot: I haz the power, 2017-09-22 11:53:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-22 11:59:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-22 11:59:34]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/21893)

[the sun, 2017-09-22 12:18:44]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2017-09-22 12:18:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org, aleloi@webrtc.org, kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3015553002/#ps100001 (title:
"remove conference mixer from presubmit.py")

[commit-bot: I haz the power, 2017-09-22 12:18:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-22 12:40:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-22 12:40:45]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[the sun, 2017-09-22 13:30:25]

The CQ bit was checked by solenberg@webrtc.org

[commit-bot: I haz the power, 2017-09-22 13:30:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-22 13:48:11]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1506087025734410,
"parent_rev": "4652e86c0c03e608674222515fd40261642365fc", "commit_rev":
"2397b9a1149ebd84e2007bea7f7bfdab88b473c6"}

[commit-bot: I haz the power, 2017-09-22 13:48:15]

Description was changed from

==========
Remove voe::OutputMixer and AudioConferenceMixer.

This code path is not used anymore.

BUG=webrtc:4690
==========

to

==========
Remove voe::OutputMixer and AudioConferenceMixer.

This code path is not used anymore.

BUG=webrtc:4690

Review-Url: https://codereview.webrtc.org/3015553002
Cr-Commit-Position: refs/heads/master@{#19929}
Committed:
https://webrtc.googlesource.com/src/+/2397b9a1149ebd84e2007bea7f7bfdab88b473c6
==========

[commit-bot: I haz the power, 2017-09-22 13:48:16]

Committed patchset #6 (id:100001) as
https://webrtc.googlesource.com/src/+/2397b9a1149ebd84e2007bea7f7bfdab88b473c6