Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 3015553002: Remove voe::OutputMixer and AudioConferenceMixer. (Closed)

Created:
3 years, 3 months ago by the sun
Modified:
3 years, 2 months ago
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove voe::OutputMixer and AudioConferenceMixer. This code path is not used anymore. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/3015553002 Cr-Commit-Position: refs/heads/master@{#19929} Committed: https://webrtc.googlesource.com/src/+/2397b9a1149ebd84e2007bea7f7bfdab88b473c6

Patch Set 1 #

Patch Set 2 : remove commented-out code #

Patch Set 3 : collapse getaudioframewithinfo/withmuted #

Patch Set 4 : rebase #

Total comments: 6

Patch Set 5 : mark functions deprecated #

Patch Set 6 : remove conference mixer from presubmit.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -2658 lines) Patch
M PRESUBMIT.py View 1 2 3 4 5 2 chunks +0 lines, -2 lines 0 comments Download
M audio/audio_receive_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M modules/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D modules/audio_conference_mixer/BUILD.gn View 1 chunk +0 lines, -80 lines 0 comments Download
D modules/audio_conference_mixer/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D modules/audio_conference_mixer/OWNERS View 1 chunk +0 lines, -6 lines 0 comments Download
D modules/audio_conference_mixer/include/audio_conference_mixer.h View 1 chunk +0 lines, -77 lines 0 comments Download
D modules/audio_conference_mixer/include/audio_conference_mixer_defines.h View 1 chunk +0 lines, -87 lines 0 comments Download
D modules/audio_conference_mixer/source/audio_conference_mixer_impl.h View 1 chunk +0 lines, -192 lines 0 comments Download
D modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc View 1 chunk +0 lines, -904 lines 0 comments Download
D modules/audio_conference_mixer/source/audio_frame_manipulator.h View 1 chunk +0 lines, -28 lines 0 comments Download
D modules/audio_conference_mixer/source/audio_frame_manipulator.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D modules/audio_conference_mixer/source/memory_pool.h View 1 chunk +0 lines, -122 lines 0 comments Download
D modules/audio_conference_mixer/source/memory_pool_posix.h View 1 chunk +0 lines, -156 lines 0 comments Download
D modules/audio_conference_mixer/source/memory_pool_win.h View 1 chunk +0 lines, -199 lines 0 comments Download
D modules/audio_conference_mixer/source/time_scheduler.h View 1 chunk +0 lines, -45 lines 0 comments Download
D modules/audio_conference_mixer/source/time_scheduler.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D modules/audio_conference_mixer/test/audio_conference_mixer_unittest.cc View 1 chunk +0 lines, -166 lines 0 comments Download
M modules/audio_mixer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M test/mock_voe_channel_proxy.h View 1 1 chunk +1 line, -1 line 0 comments Download
M voice_engine/BUILD.gn View 1 2 3 3 chunks +0 lines, -4 lines 0 comments Download
M voice_engine/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M voice_engine/channel.h View 1 2 3 6 chunks +2 lines, -11 lines 0 comments Download
M voice_engine/channel.cc View 1 2 3 4 10 chunks +29 lines, -83 lines 0 comments Download
M voice_engine/channel_proxy.h View 1 1 chunk +1 line, -1 line 0 comments Download
M voice_engine/channel_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D voice_engine/output_mixer.h View 1 chunk +0 lines, -83 lines 0 comments Download
D voice_engine/output_mixer.cc View 1 chunk +0 lines, -157 lines 0 comments Download
M voice_engine/shared_data.h View 3 chunks +0 lines, -3 lines 0 comments Download
M voice_engine/shared_data.cc View 4 chunks +0 lines, -6 lines 0 comments Download
M voice_engine/voe_base_impl.h View 1 2 3 4 1 chunk +15 lines, -15 lines 0 comments Download
M voice_engine/voe_base_impl.cc View 1 5 chunks +3 lines, -42 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
the sun
3 years, 3 months ago (2017-09-18 14:40:05 UTC) #2
the sun
On 2017/09/18 14:40:05, the sun wrote: +Karl for test/
3 years, 3 months ago (2017-09-18 14:41:26 UTC) #5
kwiberg-webrtc
lgtm for test/
3 years, 3 months ago (2017-09-18 17:43:41 UTC) #6
the sun
On 2017/09/18 17:43:41, kwiberg-webrtc wrote: > lgtm for test/ Ping Alex, Henrik...
3 years, 3 months ago (2017-09-21 07:45:11 UTC) #7
aleloi
lgtm!
3 years, 2 months ago (2017-09-22 08:42:41 UTC) #8
hlundin-webrtc
LGTM with a few questions. https://codereview.webrtc.org/3015553002/diff/60001/voice_engine/channel.cc File voice_engine/channel.cc (right): https://codereview.webrtc.org/3015553002/diff/60001/voice_engine/channel.cc#newcode650 voice_engine/channel.cc:650: audio_frame->id_ = VoEChannelId(audio_frame->id_); Out ...
3 years, 2 months ago (2017-09-22 09:17:45 UTC) #9
the sun
https://codereview.webrtc.org/3015553002/diff/60001/voice_engine/channel.cc File voice_engine/channel.cc (right): https://codereview.webrtc.org/3015553002/diff/60001/voice_engine/channel.cc#newcode650 voice_engine/channel.cc:650: audio_frame->id_ = VoEChannelId(audio_frame->id_); On 2017/09/22 09:17:44, hlundin-webrtc wrote: > ...
3 years, 2 months ago (2017-09-22 10:49:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3015553002/80001
3 years, 2 months ago (2017-09-22 11:53:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/21893)
3 years, 2 months ago (2017-09-22 11:59:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3015553002/100001
3 years, 2 months ago (2017-09-22 12:18:55 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/builds/22133)
3 years, 2 months ago (2017-09-22 12:40:45 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3015553002/100001
3 years, 2 months ago (2017-09-22 13:30:34 UTC) #22
commit-bot: I haz the power
3 years, 2 months ago (2017-09-22 13:48:16 UTC) #25
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://webrtc.googlesource.com/src/+/2397b9a1149ebd84e2007bea7f7bfdab88b473c6

Powered by Google App Engine
This is Rietveld 408576698