Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: voice_engine/channel.h

Issue 3015553002: Remove voe::OutputMixer and AudioConferenceMixer. (Closed)
Patch Set: remove conference mixer from presubmit.py Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « voice_engine/DEPS ('k') | voice_engine/channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: voice_engine/channel.h
diff --git a/voice_engine/channel.h b/voice_engine/channel.h
index f4e47eeb83e21bd7e6545f2fdaada35ad56a0656..53b8cd0ce394c51fb1846e7ba2c6ffd9189e4fe2 100644
--- a/voice_engine/channel.h
+++ b/voice_engine/channel.h
@@ -23,7 +23,6 @@
#include "modules/audio_coding/acm2/codec_manager.h"
#include "modules/audio_coding/acm2/rent_a_codec.h"
#include "modules/audio_coding/include/audio_coding_module.h"
-#include "modules/audio_conference_mixer/include/audio_conference_mixer_defines.h"
#include "modules/audio_processing/rms_level.h"
#include "modules/rtp_rtcp/include/remote_ntp_time_estimator.h"
#include "modules/rtp_rtcp/include/rtp_header_parser.h"
@@ -89,7 +88,6 @@ struct ReportBlock {
namespace voe {
-class OutputMixer;
class RtcEventLogProxy;
class RtcpRttStatsProxy;
class RtpPacketSenderProxy;
@@ -144,7 +142,6 @@ class Channel
public Transport,
public AudioPacketizationCallback, // receive encoded packets from the
// ACM
- public MixerParticipant, // supplies output mixer with audio frames
public OverheadObserver {
public:
friend class VoERtcpObserver;
@@ -162,7 +159,6 @@ class Channel
int32_t Init();
void Terminate();
int32_t SetEngineInformation(Statistics& engineStatistics,
- OutputMixer& outputMixer,
ProcessThread& moduleProcessThread,
AudioDeviceModule& audioDeviceModule,
VoiceEngineObserver* voiceEngineObserver,
@@ -283,17 +279,13 @@ class Channel
const PacketOptions& packet_options) override;
bool SendRtcp(const uint8_t* data, size_t len) override;
- // From MixerParticipant
- MixerParticipant::AudioFrameInfo GetAudioFrameWithMuted(
- int32_t id,
- AudioFrame* audioFrame) override;
- int32_t NeededFrequency(int32_t id) const override;
-
// From AudioMixer::Source.
AudioMixer::Source::AudioFrameInfo GetAudioFrameWithInfo(
int sample_rate_hz,
AudioFrame* audio_frame);
+ int PreferredSampleRate() const;
+
uint32_t InstanceId() const { return _instanceId; }
int32_t ChannelId() const { return _channelId; }
bool Playing() const { return channel_state_.Get().playing; }
@@ -433,7 +425,6 @@ class Channel
// uses
Statistics* _engineStatisticsPtr;
- OutputMixer* _outputMixerPtr;
ProcessThread* _moduleProcessThreadPtr;
AudioDeviceModule* _audioDeviceModulePtr;
VoiceEngineObserver* _voiceEngineObserverPtr; // owned by base
« no previous file with comments | « voice_engine/DEPS ('k') | voice_engine/channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698