Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: modules/audio_conference_mixer/include/audio_conference_mixer_defines.h

Issue 3015553002: Remove voe::OutputMixer and AudioConferenceMixer. (Closed)
Patch Set: remove conference mixer from presubmit.py Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: modules/audio_conference_mixer/include/audio_conference_mixer_defines.h
diff --git a/modules/audio_conference_mixer/include/audio_conference_mixer_defines.h b/modules/audio_conference_mixer/include/audio_conference_mixer_defines.h
deleted file mode 100644
index b40be233d9e6fe22d344cf0006e14f6fc48190c4..0000000000000000000000000000000000000000
--- a/modules/audio_conference_mixer/include/audio_conference_mixer_defines.h
+++ /dev/null
@@ -1,87 +0,0 @@
-/*
- * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
- *
- * Use of this source code is governed by a BSD-style license
- * that can be found in the LICENSE file in the root of the source
- * tree. An additional intellectual property rights grant can be found
- * in the file PATENTS. All contributing project authors may
- * be found in the AUTHORS file in the root of the source tree.
- */
-
-#ifndef MODULES_AUDIO_CONFERENCE_MIXER_INCLUDE_AUDIO_CONFERENCE_MIXER_DEFINES_H_
-#define MODULES_AUDIO_CONFERENCE_MIXER_INCLUDE_AUDIO_CONFERENCE_MIXER_DEFINES_H_
-
-#include "modules/include/module_common_types.h"
-#include "rtc_base/checks.h"
-#include "typedefs.h" // NOLINT(build/include)
-
-namespace webrtc {
-class MixHistory;
-
-// A callback class that all mixer participants must inherit from/implement.
-class MixerParticipant
-{
-public:
- // The implementation of this function should update audioFrame with new
- // audio every time it's called.
- //
- // If it returns -1, the frame will not be added to the mix.
- //
- // NOTE: This function should not be called. It will remain for a short
- // time so that subclasses can override it without getting warnings.
- // TODO(henrik.lundin) Remove this function.
- virtual int32_t GetAudioFrame(int32_t id,
- AudioFrame* audioFrame) {
- RTC_CHECK(false);
- return -1;
- }
-
-
- // The implementation of GetAudioFrameWithMuted should update audio_frame
- // with new audio every time it's called. The return value will be
- // interpreted as follows.
- enum class AudioFrameInfo {
- kNormal, // The samples in audio_frame are valid and should be used.
- kMuted, // The samples in audio_frame should not be used, but should be
- // implicitly interpreted as zero. Other fields in audio_frame
- // may be read and should contain meaningful values.
- kError // audio_frame will not be used.
- };
-
- virtual AudioFrameInfo GetAudioFrameWithMuted(int32_t id,
- AudioFrame* audio_frame) {
- return GetAudioFrame(id, audio_frame) == -1 ?
- AudioFrameInfo::kError :
- AudioFrameInfo::kNormal;
- }
-
- // Returns true if the participant was mixed this mix iteration.
- bool IsMixed() const;
-
- // This function specifies the sampling frequency needed for the AudioFrame
- // for future GetAudioFrame(..) calls.
- virtual int32_t NeededFrequency(int32_t id) const = 0;
-
- MixHistory* _mixHistory;
-protected:
- MixerParticipant();
- virtual ~MixerParticipant();
-};
-
-class AudioMixerOutputReceiver
-{
-public:
- // This callback function provides the mixed audio for this mix iteration.
- // Note that uniqueAudioFrames is an array of AudioFrame pointers with the
- // size according to the size parameter.
- virtual void NewMixedAudio(const int32_t id,
- const AudioFrame& generalAudioFrame,
- const AudioFrame** uniqueAudioFrames,
- const uint32_t size) = 0;
-protected:
- AudioMixerOutputReceiver() {}
- virtual ~AudioMixerOutputReceiver() {}
-};
-} // namespace webrtc
-
-#endif // MODULES_AUDIO_CONFERENCE_MIXER_INCLUDE_AUDIO_CONFERENCE_MIXER_DEFINES_H_

Powered by Google App Engine
This is Rietveld 408576698