Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 3012983002: Remove RtpPacketToSend::GetHeader as almost unused. (Closed)

Created:
3 years, 3 months ago by danilchap
Modified:
3 years, 3 months ago
Reviewers:
eladalon
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove RtpPacketToSend::GetHeader as almost unused. Merge rtp::Packet::GetHeader into RtpPacketReceived::GetHeader removing error-prone code where latter shadow former version BUG=None Review-Url: https://codereview.webrtc.org/3012983002 Cr-Commit-Position: refs/heads/master@{#19784} Committed: https://chromium.googlesource.com/external/webrtc/+/ce25181714243770e4eff3a636ae8d49eca6d92b

Patch Set 1 #

Patch Set 2 : -forward declare of RTPHeader #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -59 lines) Patch
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.h View 1 3 chunks +1 line, -6 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet.cc View 2 chunks +0 lines, -38 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_received.h View 1 chunk +3 lines, -4 lines 0 comments Download
A webrtc/modules/rtp_rtcp/source/rtp_packet_received.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 3 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
danilchap
3 years, 3 months ago (2017-09-11 16:17:14 UTC) #2
eladalon
Assuming the contents of the function were moved without being modified, lgtm.
3 years, 3 months ago (2017-09-11 17:05:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3012983002/20001
3 years, 3 months ago (2017-09-11 19:21:46 UTC) #10
commit-bot: I haz the power
3 years, 3 months ago (2017-09-11 19:24:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/ce25181714243770e4eff3a63...

Powered by Google App Engine
This is Rietveld 408576698