Remove RtpPacketToSend::GetHeader as almost unused.

webrtc/modules/rtp_rtcp/source/rtp_packet.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_PACKET_H_
 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_PACKET_H_
 
 #include <vector>
 
 #include "webrtc/api/array_view.h"
 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
 #include "webrtc/rtc_base/basictypes.h"
 #include "webrtc/rtc_base/copyonwritebuffer.h"
 
 namespace webrtc {
-struct RTPHeader;
 class RtpHeaderExtensionMap;
 class Random;
 
 namespace rtp {
 class Packet {
  public:
   using ExtensionType = RTPExtensionType;
   using ExtensionManager = RtpHeaderExtensionMap;
   static constexpr size_t kMaxExtensionHeaders = 14;
   static constexpr int kMinExtensionId = 1;
@@ skipping 10 matching lines @@
   void IdentifyExtensions(const ExtensionManager& extensions);
 
   // Header.
   bool Marker() const;
   uint8_t PayloadType() const;
   uint16_t SequenceNumber() const;
   uint32_t Timestamp() const;
   uint32_t Ssrc() const;
   std::vector<uint32_t> Csrcs() const;
 
-  // TODO(danilchap): Remove this function when all code update to use RtpPacket
-  // directly. Function is there just for easier backward compatibilty.
-  void GetHeader(RTPHeader* header) const;
-
   size_t headers_size() const;
 
   // Payload.
   size_t payload_size() const;
   size_t padding_size() const;
   rtc::ArrayView<const uint8_t> payload() const;
 
   // Buffer.
   rtc::CopyOnWriteBuffer Buffer() const;
   size_t capacity() const;
@@ skipping 54 matching lines @@
 
  protected:
   // |extensions| required for SetExtension/ReserveExtension functions during
   // packet creating and used if available in Parse function.
   // Adding and getting extensions will fail until |extensions| is
   // provided via constructor or IdentifyExtensions function.
   Packet();
   explicit Packet(const ExtensionManager* extensions);
   Packet(const Packet&);
   Packet(const ExtensionManager* extensions, size_t capacity);
-  virtual ~Packet();
+  ~Packet();
 
   Packet& operator=(const Packet&) = default;
 
  private:
   struct ExtensionInfo {
     ExtensionType type;
     uint16_t offset;
     uint8_t length;
   };
 
@@ skipping 56 matching lines @@
   auto buffer = AllocateExtension(Extension::kId, Extension::kValueSizeBytes);
   if (buffer.empty())
     return false;
   memset(buffer.data(), 0, Extension::kValueSizeBytes);
   return true;
 }
 }  // namespace rtp
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_PACKET_H_