Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc

Issue 3012983002: Remove RtpPacketToSend::GetHeader as almost unused. (Closed)
Patch Set: -forward declare of RTPHeader Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_packet_received.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc b/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc
index 5a4775959e7b8cdc5232d8440ab02bcfb559a525..860f193d0c323d31c13c21ffe7ca8c5d09e492f1 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc
@@ -500,9 +500,6 @@ TEST_P(RtpSenderTestWithoutPacer, WritesTimestampToTimingExtension) {
packet->SetExtension<VideoTimingExtension>(kVideoTiming);
EXPECT_TRUE(rtp_sender_->AssignSequenceNumber(packet.get()));
size_t packet_size = packet->size();
- webrtc::RTPHeader rtp_header;
-
- packet->GetHeader(&rtp_header);
const int kStoredTimeInMs = 100;
fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
@@ -513,10 +510,10 @@ TEST_P(RtpSenderTestWithoutPacer, WritesTimestampToTimingExtension) {
EXPECT_EQ(1, transport_.packets_sent());
EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
- transport_.last_sent_packet().GetHeader(&rtp_header);
- EXPECT_TRUE(rtp_header.extension.has_video_timing);
- EXPECT_EQ(kStoredTimeInMs,
- rtp_header.extension.video_timing.pacer_exit_delta_ms);
+ VideoSendTiming video_timing;
+ EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
+ &video_timing));
+ EXPECT_EQ(kStoredTimeInMs, video_timing.pacer_exit_delta_ms);
fake_clock_.AdvanceTimeMilliseconds(kStoredTimeInMs);
rtp_sender_->TimeToSendPacket(kSsrc, kSeqNum, capture_time_ms, false,
@@ -525,10 +522,9 @@ TEST_P(RtpSenderTestWithoutPacer, WritesTimestampToTimingExtension) {
EXPECT_EQ(2, transport_.packets_sent());
EXPECT_EQ(packet_size, transport_.last_sent_packet().size());
- transport_.last_sent_packet().GetHeader(&rtp_header);
- EXPECT_TRUE(rtp_header.extension.has_video_timing);
- EXPECT_EQ(kStoredTimeInMs * 2,
- rtp_header.extension.video_timing.pacer_exit_delta_ms);
+ EXPECT_TRUE(transport_.last_sent_packet().GetExtension<VideoTimingExtension>(
+ &video_timing));
+ EXPECT_EQ(kStoredTimeInMs * 2, video_timing.pacer_exit_delta_ms);
}
TEST_P(RtpSenderTest, TrafficSmoothingWithExtensions) {
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_packet_received.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698