Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 3011513002: Removing video_{receive,send}_stream.h stub headers (Closed)

Created:
3 years, 3 months ago by mbonadei
Modified:
3 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing video_{receive,send}_stream.h stub headers. These headers have been moved to the right place in https://codereview.webrtc.org/3000253002 and in https://codereview.webrtc.org/3007553002/ we stopped to depend on them internally. This CL tries to remove the stubs from the root directory so we can unblock crbug.com/611808. BUG=webrtc:8107 Review-Url: https://codereview.webrtc.org/3011513002 Cr-Commit-Position: refs/heads/master@{#19575} Committed: https://chromium.googlesource.com/external/webrtc/+/dad6198eeefe12de191a1287d24d2341ff3c0e82

Patch Set 1 #

Patch Set 2 : Cleaning up DEPS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
M webrtc/DEPS View 1 1 chunk +0 lines, -2 lines 0 comments Download
D webrtc/video_receive_stream.h View 1 chunk +0 lines, -18 lines 0 comments Download
D webrtc/video_send_stream.h View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
mbonadei
3 years, 3 months ago (2017-08-28 14:13:35 UTC) #3
mbonadei
I forgot that chromium trybots always fail when we remove a file. They are not ...
3 years, 3 months ago (2017-08-28 14:24:55 UTC) #4
mbonadei
3 years, 3 months ago (2017-08-28 14:25:06 UTC) #5
kwiberg-webrtc
lgtm
3 years, 3 months ago (2017-08-29 09:44:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3011513002/20001
3 years, 3 months ago (2017-08-29 10:13:30 UTC) #9
commit-bot: I haz the power
3 years, 3 months ago (2017-08-29 10:35:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/dad6198eeefe12de191a1287d...

Powered by Google App Engine
This is Rietveld 408576698