Move video send/receive stream headers to webrtc/call.

Move video send/receive stream headers to webrtc/call.

Moved the headers video_receive_stream.h and video_send_stream.h from
webrtc/ into webrtc/call/ as part of the Slim and Modular work.

The GN target webrtc:video_stream_api has moved to
webrtc/call:video_stream_api.

There are headers left in webrtc/ with the same name including the
moved headers in webrtc/call/ for not breaking external projects
depending on WebRTC.

At the same time, some minor cleanup is done: Non-pure-virtual functions declared in the two affected headers now have definitions in the same target. After making this change, our 'chromium-style' plugin detected some style violations that have now been fixed: non-inlined constructors and destructors have been added to a number of classes, both inside the GN target of the two affected headers, and in other targets.

BUG=webrtc:8107
Review-Url: https://codereview.webrtc.org/3000253002
Cr-Commit-Position: refs/heads/master@{#19448}
Committed: https://chromium.googlesource.com/external/webrtc/+/440b6d9a0f22d9059ca330fd597dcfd0d6fc5377

[aleloi, 2017-08-21 06:51:35]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 06:51:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[aleloi, 2017-08-21 06:56:47]

Description was changed from

==========
Move video send/receive stream headers to webrtc/api.

Moved the headers video_receive_stream.h and video_send_stream.h from
webrtc/ into webrtc/ as part of the Slim and Modular work.

The GN target webrtc:video_stream_api has moved to
webrtc/api:video_stream_api.

There are headers left in webrtc/ with the same name including the
moved headers in webrtc/api/ for not breaking external projects
depending on WebRTC.

BUG=webrtc:5878
==========

to

==========
Move video send/receive stream headers to webrtc/api.

Moved the headers video_receive_stream.h and video_send_stream.h from
webrtc/ into webrtc/ as part of the Slim and Modular work.

The GN target webrtc:video_stream_api has moved to
webrtc/api:video_stream_api.

There are headers left in webrtc/ with the same name including the
moved headers in webrtc/api/ for not breaking external projects
depending on WebRTC.

BUG=webrtc:8108
==========

[commit-bot: I haz the power, 2017-08-21 06:57:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 06:57:11]

Dry run: Try jobs failed on following builders:
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)

[aleloi, 2017-08-21 06:57:12]

Description was changed from

==========
Move video send/receive stream headers to webrtc/api.

Moved the headers video_receive_stream.h and video_send_stream.h from
webrtc/ into webrtc/ as part of the Slim and Modular work.

The GN target webrtc:video_stream_api has moved to
webrtc/api:video_stream_api.

There are headers left in webrtc/ with the same name including the
moved headers in webrtc/api/ for not breaking external projects
depending on WebRTC.

BUG=webrtc:8108
==========

to

==========
Move video send/receive stream headers to webrtc/api.

Moved the headers video_receive_stream.h and video_send_stream.h from
webrtc/ into webrtc/ as part of the Slim and Modular work.

The GN target webrtc:video_stream_api has moved to
webrtc/api:video_stream_api.

There are headers left in webrtc/ with the same name including the
moved headers in webrtc/api/ for not breaking external projects
depending on WebRTC.

BUG=webrtc:8107
==========

[aleloi, 2017-08-21 06:57:12]

aleloi@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[aleloi, 2017-08-21 06:58:54]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 06:59:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-21 07:04:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 07:04:31]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20418)

[aleloi, 2017-08-21 07:33:43]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 07:33:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-21 07:39:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 07:39:03]

Dry run: Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20421)

[aleloi, 2017-08-21 07:58:04]

PTAL!

[kwiberg-webrtc, 2017-08-21 08:51:00]

kwiberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2017-08-21 08:51:00]

https://codereview.webrtc.org/3000253002/diff/40001/webrtc/api/BUILD.gn
File webrtc/api/BUILD.gn (right):

https://codereview.webrtc.org/3000253002/diff/40001/webrtc/api/BUILD.gn#newco...
webrtc/api/BUILD.gn:201: "video_send_stream.h",
These .h files declare functions that they don't define. In order to avoid both
insufficient dependencies and circular dependencies, the .cc files that define
the functions should be in the same build target.

[aleloi, 2017-08-21 13:26:31]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 13:26:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-21 13:29:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 13:29:45]

Dry run: Try jobs failed on following builders:
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/27228)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/28365)
  win_x64_clang_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_clang_dbg/build...)

[aleloi, 2017-08-21 13:33:31]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-21 13:33:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[aleloi, 2017-08-21 13:39:28]

Description was changed from

==========
Move video send/receive stream headers to webrtc/api.

Moved the headers video_receive_stream.h and video_send_stream.h from
webrtc/ into webrtc/ as part of the Slim and Modular work.

The GN target webrtc:video_stream_api has moved to
webrtc/api:video_stream_api.

There are headers left in webrtc/ with the same name including the
moved headers in webrtc/api/ for not breaking external projects
depending on WebRTC.

BUG=webrtc:8107
==========

to

==========
Move video send/receive stream headers to webrtc/api.

Moved the headers video_receive_stream.h and video_send_stream.h from
webrtc/ into webrtc/ as part of the Slim and Modular work.

The GN target webrtc:video_stream_api has moved to
webrtc/api:video_stream_api.

There are headers left in webrtc/ with the same name including the
moved headers in webrtc/api/ for not breaking external projects
depending on WebRTC.

At the same time, some minor cleanup is done: Non-pure-virtual functions
declared in the two affected headers now have definitions in the same target.
After making this change, our 'chromium-style' plugin detected some style
violations that have now been fixed: non-inlined constructors and destructors
have been added to a number of classes, both inside the GN target of the two
affected headers, and in other targets.

BUG=webrtc:8107
==========

[aleloi, 2017-08-21 13:40:01]

Done, PTAL again :-)

https://codereview.webrtc.org/3000253002/diff/40001/webrtc/api/BUILD.gn
File webrtc/api/BUILD.gn (right):

https://codereview.webrtc.org/3000253002/diff/40001/webrtc/api/BUILD.gn#newco...
webrtc/api/BUILD.gn:201: "video_send_stream.h",
On 2017/08/21 08:51:00, kwiberg-webrtc wrote:
> These .h files declare functions that they don't define. In order to avoid
both
> insufficient dependencies and circular dependencies, the .cc files that define
> the functions should be in the same build target.

Thanks! Good that you noticed!

[kjellander_webrtc, 2017-08-21 13:45:28]

Thanks for this! All looks good except
	webrtc/test/testsupport/trace_to_stderr.cc?

https://codereview.webrtc.org/3000253002/diff/80001/webrtc/test/testsupport/t...
File webrtc/test/testsupport/trace_to_stderr.cc (right):

https://codereview.webrtc.org/3000253002/diff/80001/webrtc/test/testsupport/t...
webrtc/test/testsupport/trace_to_stderr.cc:49: ) {
I assume this should be restored?

[commit-bot: I haz the power, 2017-08-21 15:05:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-21 15:05:07]

Dry run: This issue passed the CQ dry run.

[aleloi, 2017-08-22 07:57:04]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-22 07:57:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-22 08:22:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-22 08:22:58]

Dry run: This issue passed the CQ dry run.

[aleloi, 2017-08-22 09:02:46]

The CQ bit was checked by aleloi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-22 09:02:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[aleloi, 2017-08-22 09:03:18]

I've put the headers in webrtc/call, PTAL on the latest changes!

https://codereview.webrtc.org/3000253002/diff/80001/webrtc/test/testsupport/t...
File webrtc/test/testsupport/trace_to_stderr.cc (right):

https://codereview.webrtc.org/3000253002/diff/80001/webrtc/test/testsupport/t...
webrtc/test/testsupport/trace_to_stderr.cc:49: ) {
On 2017/08/21 13:45:28, kjellander_webrtc wrote:
> I assume this should be restored?

Done.

[aleloi, 2017-08-22 09:04:03]

https://codereview.webrtc.org/3000253002/diff/120001/webrtc/BUILD.gn
File webrtc/BUILD.gn (right):

https://codereview.webrtc.org/3000253002/diff/120001/webrtc/BUILD.gn#newcode29
webrtc/BUILD.gn:29: 
Blank line added by 'git cl format'

[kjellander_webrtc, 2017-08-22 09:25:05]

lgtm

[commit-bot: I haz the power, 2017-08-22 09:31:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-22 09:31:50]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-08-22 11:21:15]

lgtm, but update the commit message---it still talks about api/.

Also, for next time: it's easier to review if you fix chromium style checker
errors in one CL and shuffle code around in a separate CL.

https://codereview.webrtc.org/3000253002/diff/120001/webrtc/BUILD.gn
File webrtc/BUILD.gn (right):

https://codereview.webrtc.org/3000253002/diff/120001/webrtc/BUILD.gn#newcode29
webrtc/BUILD.gn:29: 
On 2017/08/22 09:04:03, aleloi wrote:
> Blank line added by 'git cl format'

Acknowledged.

[aleloi, 2017-08-22 12:35:36]

Description was changed from

==========
Move video send/receive stream headers to webrtc/api.

Moved the headers video_receive_stream.h and video_send_stream.h from
webrtc/ into webrtc/ as part of the Slim and Modular work.

The GN target webrtc:video_stream_api has moved to
webrtc/api:video_stream_api.

There are headers left in webrtc/ with the same name including the
moved headers in webrtc/api/ for not breaking external projects
depending on WebRTC.

At the same time, some minor cleanup is done: Non-pure-virtual functions
declared in the two affected headers now have definitions in the same target.
After making this change, our 'chromium-style' plugin detected some style
violations that have now been fixed: non-inlined constructors and destructors
have been added to a number of classes, both inside the GN target of the two
affected headers, and in other targets.

BUG=webrtc:8107
==========

to

==========
Move video send/receive stream headers to webrtc/call.

Moved the headers video_receive_stream.h and video_send_stream.h from
webrtc/ into webrtc/call/ as part of the Slim and Modular work.

The GN target webrtc:video_stream_api has moved to
webrtc/call:video_stream_api.

There are headers left in webrtc/ with the same name including the
moved headers in webrtc/call/ for not breaking external projects
depending on WebRTC.

At the same time, some minor cleanup is done: Non-pure-virtual functions
declared in the two affected headers now have definitions in the same target.
After making this change, our 'chromium-style' plugin detected some style
violations that have now been fixed: non-inlined constructors and destructors
have been added to a number of classes, both inside the GN target of the two
affected headers, and in other targets.

BUG=webrtc:8107
==========

[aleloi, 2017-08-22 12:38:22]

On 2017/08/22 11:21:15, kwiberg-webrtc wrote:
> lgtm, but update the commit message---it still talks about api/.
> 
> Also, for next time: it's easier to review if you fix chromium style checker
> errors in one CL and shuffle code around in a separate CL.
> 
> https://codereview.webrtc.org/3000253002/diff/120001/webrtc/BUILD.gn
> File webrtc/BUILD.gn (right):
> 
> https://codereview.webrtc.org/3000253002/diff/120001/webrtc/BUILD.gn#newcode29
> webrtc/BUILD.gn:29: 
> On 2017/08/22 09:04:03, aleloi wrote:
> > Blank line added by 'git cl format'
> 
> Acknowledged.

Thanks, done!

[aleloi, 2017-08-22 12:38:32]

The CQ bit was checked by aleloi@webrtc.org

[commit-bot: I haz the power, 2017-08-22 12:38:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-22 12:43:24]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1503405512017600,
"parent_rev": "aaaf2db253e0155403d9ac5925351af046ed0d7c", "commit_rev":
"440b6d9a0f22d9059ca330fd597dcfd0d6fc5377"}

[commit-bot: I haz the power, 2017-08-22 12:43:27]

Description was changed from

==========
Move video send/receive stream headers to webrtc/call.

Moved the headers video_receive_stream.h and video_send_stream.h from
webrtc/ into webrtc/call/ as part of the Slim and Modular work.

The GN target webrtc:video_stream_api has moved to
webrtc/call:video_stream_api.

There are headers left in webrtc/ with the same name including the
moved headers in webrtc/call/ for not breaking external projects
depending on WebRTC.

At the same time, some minor cleanup is done: Non-pure-virtual functions
declared in the two affected headers now have definitions in the same target.
After making this change, our 'chromium-style' plugin detected some style
violations that have now been fixed: non-inlined constructors and destructors
have been added to a number of classes, both inside the GN target of the two
affected headers, and in other targets.

BUG=webrtc:8107
==========

to

==========
Move video send/receive stream headers to webrtc/call.

Moved the headers video_receive_stream.h and video_send_stream.h from
webrtc/ into webrtc/call/ as part of the Slim and Modular work.

The GN target webrtc:video_stream_api has moved to
webrtc/call:video_stream_api.

There are headers left in webrtc/ with the same name including the
moved headers in webrtc/call/ for not breaking external projects
depending on WebRTC.

At the same time, some minor cleanup is done: Non-pure-virtual functions
declared in the two affected headers now have definitions in the same target.
After making this change, our 'chromium-style' plugin detected some style
violations that have now been fixed: non-inlined constructors and destructors
have been added to a number of classes, both inside the GN target of the two
affected headers, and in other targets.

BUG=webrtc:8107

Review-Url: https://codereview.webrtc.org/3000253002
Cr-Commit-Position: refs/heads/master@{#19448}
Committed:
https://chromium.googlesource.com/external/webrtc/+/440b6d9a0f22d9059ca330fd5...
==========

[commit-bot: I haz the power, 2017-08-22 12:43:29]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/440b6d9a0f22d9059ca330fd5...