Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 3007553002: Removing dependencies on stub headers within WebRTC. (Closed)

Created:
3 years, 4 months ago by mbonadei
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing dependencies on stub headers within WebRTC. Headers webrtc/video_receive_stream.h and webrtc/video_send_stream.h have been moved to webrtc/call in https://codereview.webrtc.org/3000253002, this CL is just switching WebRTC internal dependencies to actual headers instead of depending on the backward compatibility ones. BUG=webrtc:8107 Review-Url: https://codereview.webrtc.org/3007553002 Cr-Commit-Position: refs/heads/master@{#19561} Committed: https://chromium.googlesource.com/external/webrtc/+/5212700c79f713f0ff009af761064fc30afe5960

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M webrtc/media/engine/fakewebrtccall.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/include/video_codec_initializer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/frame_generator_capturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/rtp_rtcp_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/vcm_capturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/send_delay_stats.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_stream_encoder.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
mbonadei
3 years, 4 months ago (2017-08-25 11:22:46 UTC) #2
kjellander_webrtc
lgtm
3 years, 4 months ago (2017-08-25 11:24:42 UTC) #3
kwiberg-webrtc
lgtm
3 years, 3 months ago (2017-08-28 12:43:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007553002/1
3 years, 3 months ago (2017-08-28 12:45:31 UTC) #8
commit-bot: I haz the power
3 years, 3 months ago (2017-08-28 13:46:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5212700c79f713f0ff009af76...

Powered by Google App Engine
This is Rietveld 408576698