Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 3011023002: Reland of Add //build/android/pylib/results/ to Android isolate packaging (Closed)

Created:
3 years, 3 months ago by kjellander_webrtc
Modified:
3 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3008083004/ ) Reason for revert: Now making sure the data attribute contents is not wiped for non-Android targets, which caused every test relying on resources to break. Original issue's description: > Revert of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3006103002/ ) > > Reason for revert: > Breaks memcheck bot: https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/11554 > > Edward: do you understand why? I'll run a full CQ set before relanding for sure. > > Original issue's description: > > Add //build/android/pylib/results/ to Android isolate packaging > > > > This is needed before relanding > > https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228 > > > > TESTED= > > I built tools_unittests and verified build/android/pylib/results/presentation/test_results_presentation.py > > is listed in the .isolated file: > > OUT=out/android-Release > > TEST=tools_unittests > > tools_webrtc/mb/mb.py isolate //$OUT $TEST > > tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i $OUT/$TEST.isolate -s $OUT/$TEST.isolated > > > > BUG=chromium:717417 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/3006103002 > > Cr-Commit-Position: refs/heads/master@{#19695} > > Committed: https://chromium.googlesource.com/external/webrtc/+/f8ff0282c6b605f16fa5464b9496be1f6bac35ed > > TBR=ehmaldonado@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:717417 > > Review-Url: https://codereview.webrtc.org/3008083004 > Cr-Commit-Position: refs/heads/master@{#19696} > Committed: https://chromium.googlesource.com/external/webrtc/+/e5abac443a5cbaf5acdcdc7c0876f8ba2aa48ad1 BUG=chromium:717417 Review-Url: https://codereview.webrtc.org/3011023002 Cr-Commit-Position: refs/heads/master@{#19707} Committed: https://chromium.googlesource.com/external/webrtc/+/2e75bd4ed8a6111f9bc5b71de23a1dee41137415

Patch Set 1 #

Patch Set 2 : Making sure data is working for all targets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M webrtc/webrtc.gni View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
kjellander_webrtc
Created Reland of Add //build/android/pylib/results/ to Android isolate packaging
3 years, 3 months ago (2017-09-06 08:41:43 UTC) #1
kjellander_webrtc
3 years, 3 months ago (2017-09-06 08:46:22 UTC) #4
ehmaldonado_webrtc
On 2017/09/06 08:46:22, kjellander_webrtc wrote: LGTM
3 years, 3 months ago (2017-09-06 09:26:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3011023002/40001
3 years, 3 months ago (2017-09-06 10:00:31 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/2e75bd4ed8a6111f9bc5b71de23a1dee41137415
3 years, 3 months ago (2017-09-06 10:14:29 UTC) #17
ehmaldonado_webrtc
3 years, 3 months ago (2017-09-06 18:46:50 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.webrtc.org/3011063002/ by ehmaldonado@webrtc.org.

The reason for reverting is: This is not needed, since the script is run on the
bot, not on a swarming task..

Powered by Google App Engine
This is Rietveld 408576698