Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 3006103002: Add //build/android/pylib/results/ to Android isolate packaging (Closed)

Created:
3 years, 3 months ago by kjellander_webrtc
Modified:
3 years, 3 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add //build/android/pylib/results/ to Android isolate packaging This is needed before relanding https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228 TESTED= I built tools_unittests and verified build/android/pylib/results/presentation/test_results_presentation.py is listed in the .isolated file: OUT=out/android-Release TEST=tools_unittests tools_webrtc/mb/mb.py isolate //$OUT $TEST tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i $OUT/$TEST.isolate -s $OUT/$TEST.isolated BUG=chromium:717417 NOTRY=True Review-Url: https://codereview.webrtc.org/3006103002 Cr-Commit-Position: refs/heads/master@{#19695} Committed: https://chromium.googlesource.com/external/webrtc/+/f8ff0282c6b605f16fa5464b9496be1f6bac35ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M webrtc/webrtc.gni View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kjellander_webrtc
The failing bot was because of https://bugs.chromium.org/p/chromium/issues/detail?id=761927
3 years, 3 months ago (2017-09-05 14:34:46 UTC) #2
ehmaldonado_webrtc
On 2017/09/05 14:34:46, kjellander_webrtc wrote: > The failing bot was because of > https://bugs.chromium.org/p/chromium/issues/detail?id=761927 lgtm ...
3 years, 3 months ago (2017-09-05 15:03:27 UTC) #3
kjellander_webrtc
On 2017/09/05 15:03:27, ehmaldonado_webrtc wrote: > On 2017/09/05 14:34:46, kjellander_webrtc wrote: > > The failing ...
3 years, 3 months ago (2017-09-05 16:36:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006103002/1
3 years, 3 months ago (2017-09-05 17:00:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/f8ff0282c6b605f16fa5464b9496be1f6bac35ed
3 years, 3 months ago (2017-09-05 17:03:36 UTC) #10
kjellander_webrtc
3 years, 3 months ago (2017-09-05 17:14:45 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/3008083004/ by kjellander@webrtc.org.

The reason for reverting is: Breaks memcheck bot:
https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/1...

Edward: do you understand why? I'll run a full CQ set before relanding for
sure..

Powered by Google App Engine
This is Rietveld 408576698