Revert of Add //build/android/pylib/results/ to Android isolate packaging

Revert of Add //build/android/pylib/results/ to Android isolate packaging (patchset #1 id:1 of https://codereview.webrtc.org/3006103002/ )

Reason for revert:
Breaks memcheck bot: https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/11554

Edward: do you understand why? I'll run a full CQ set before relanding for sure.

Original issue's description:
> Add //build/android/pylib/results/ to Android isolate packaging
> 
> This is needed before relanding
> https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
> 
> TESTED=
> I built tools_unittests and verified build/android/pylib/results/presentation/test_results_presentation.py
> is listed in the .isolated file:
> OUT=out/android-Release
> TEST=tools_unittests
> tools_webrtc/mb/mb.py isolate //$OUT $TEST
> tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com -i $OUT/$TEST.isolate -s $OUT/$TEST.isolated
> 
> BUG=chromium:717417
> NOTRY=True
> 
> Review-Url: https://codereview.webrtc.org/3006103002
> Cr-Commit-Position: refs/heads/master@{#19695}
> Committed: https://chromium.googlesource.com/external/webrtc/+/f8ff0282c6b605f16fa5464b9496be1f6bac35ed

TBR=ehmaldonado@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:717417
Review-Url: https://codereview.webrtc.org/3008083004
Cr-Commit-Position: refs/heads/master@{#19696}
Committed: https://chromium.googlesource.com/external/webrtc/+/e5abac443a5cbaf5acdcdc7c0876f8ba2aa48ad1

[kjellander_webrtc, 2017-09-05 17:14:46]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2017-09-05 17:14:46]

Created Revert of Add //build/android/pylib/results/ to Android isolate
packaging

[commit-bot: I haz the power, 2017-09-05 17:14:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-05 17:14:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1504631686201590, "parent_rev":
"f8ff0282c6b605f16fa5464b9496be1f6bac35ed", "commit_rev":
"e5abac443a5cbaf5acdcdc7c0876f8ba2aa48ad1"}

[commit-bot: I haz the power, 2017-09-05 17:14:56]

Description was changed from

==========
Revert of Add //build/android/pylib/results/ to Android isolate packaging
(patchset #1 id:1 of https://codereview.webrtc.org/3006103002/ )

Reason for revert:
Breaks memcheck bot:
https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/1...

Edward: do you understand why? I'll run a full CQ set before relanding for sure.

Original issue's description:
> Add //build/android/pylib/results/ to Android isolate packaging
> 
> This is needed before relanding
> https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
> 
> TESTED=
> I built tools_unittests and verified
build/android/pylib/results/presentation/test_results_presentation.py
> is listed in the .isolated file:
> OUT=out/android-Release
> TEST=tools_unittests
> tools_webrtc/mb/mb.py isolate //$OUT $TEST
> tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com
-i $OUT/$TEST.isolate -s $OUT/$TEST.isolated
> 
> BUG=chromium:717417
> NOTRY=True
> 
> Review-Url: https://codereview.webrtc.org/3006103002
> Cr-Commit-Position: refs/heads/master@{#19695}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/f8ff0282c6b605f16fa5464b9...

TBR=ehmaldonado@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:717417
==========

to

==========
Revert of Add //build/android/pylib/results/ to Android isolate packaging
(patchset #1 id:1 of https://codereview.webrtc.org/3006103002/ )

Reason for revert:
Breaks memcheck bot:
https://build.chromium.org/p/client.webrtc/builders/Linux%20Memcheck/builds/1...

Edward: do you understand why? I'll run a full CQ set before relanding for sure.

Original issue's description:
> Add //build/android/pylib/results/ to Android isolate packaging
> 
> This is needed before relanding
> https://chromium-review.googlesource.com/c/chromium/tools/build/+/619228
> 
> TESTED=
> I built tools_unittests and verified
build/android/pylib/results/presentation/test_results_presentation.py
> is listed in the .isolated file:
> OUT=out/android-Release
> TEST=tools_unittests
> tools_webrtc/mb/mb.py isolate //$OUT $TEST
> tools/swarming_client/isolate.py archive -I https://isolateserver.appspot.com
-i $OUT/$TEST.isolate -s $OUT/$TEST.isolated
> 
> BUG=chromium:717417
> NOTRY=True
> 
> Review-Url: https://codereview.webrtc.org/3006103002
> Cr-Commit-Position: refs/heads/master@{#19695}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/f8ff0282c6b605f16fa5464b9...

TBR=ehmaldonado@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:717417

Review-Url: https://codereview.webrtc.org/3008083004
Cr-Commit-Position: refs/heads/master@{#19696}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e5abac443a5cbaf5acdcdc7c0...
==========

[commit-bot: I haz the power, 2017-09-05 17:14:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e5abac443a5cbaf5acdcdc7c0...

[kjellander_webrtc, 2017-09-05 17:16:25]

On 2017/09/05 17:14:57, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/external/webrtc/+/e5abac443a5cbaf5acdcdc7c0...

It appears it breaks every bot that runs tests. I guess it must be overriding
the data attribute or something.
http://build.chromium.org/p/client.webrtc/builders/Win32%20ASan/builds/1606
http://build.chromium.org/p/client.webrtc/builders/Linux%20UBSan%20vptr/build...

[ehmaldonado_webrtc, 2017-09-05 17:22:33]

https://codereview.webrtc.org/3008083004/diff/1/webrtc/webrtc.gni
File webrtc/webrtc.gni (left):

https://codereview.webrtc.org/3008083004/diff/1/webrtc/webrtc.gni#oldcode287
webrtc/webrtc.gni:287: if (defined(invoker.data)) {
D'oh, this should be outside the if (!build_with_chromium && is_android), so
that data is set also for non-android builds.

[kjellander_webrtc, 2017-09-06 08:41:42]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/3011023002/ by kjellander@webrtc.org.

The reason for reverting is: Creating CL for Reland.

[kjellander_webrtc, 2017-09-06 08:43:21]

https://codereview.webrtc.org/3008083004/diff/1/webrtc/webrtc.gni
File webrtc/webrtc.gni (left):

https://codereview.webrtc.org/3008083004/diff/1/webrtc/webrtc.gni#oldcode287
webrtc/webrtc.gni:287: if (defined(invoker.data)) {
On 2017/09/05 17:22:33, ehmaldonado_webrtc wrote:
> D'oh, this should be outside the if (!build_with_chromium && is_android), so
> that data is set also for non-android builds.

Yeah, that's probably it. I'll make that change in the reland CL:
https://codereview.webrtc.org/3011023002/