Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Issue 3010273002: Make CreateRtcLogStreamConfig() return a std::unique_ptr (Closed)

Created:
3 years, 3 months ago by eladalon
Modified:
3 years, 3 months ago
Reviewers:
terelius, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make CreateRtcLogStreamConfig() return a std::unique_ptr This is done for two reasons: 1. This will be useful in an upcoming CL, when all logging will be done with one function that accepts a std::unique_ptr<RtcEvent>. 2. Ensure no unnecessary copies when the compiler fails to optimize. BUG=webrtc:8111 TBR=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/3010273002 Cr-Commit-Position: refs/heads/master@{#19746} Committed: https://chromium.googlesource.com/external/webrtc/+/8ec568a9ff9b30dd7e8881a0c1bdbc418dc05ff4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -33 lines) Patch
M webrtc/call/call.cc View 5 chunks +33 lines, -33 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
eladalon
PTAL
3 years, 3 months ago (2017-09-08 12:01:14 UTC) #2
terelius
lgtm
3 years, 3 months ago (2017-09-08 12:28:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010273002/1
3 years, 3 months ago (2017-09-08 12:44:52 UTC) #7
commit-bot: I haz the power
3 years, 3 months ago (2017-09-08 13:15:57 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8ec568a9ff9b30dd7e8881a0c...

Powered by Google App Engine
This is Rietveld 408576698