Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 3006213002: Remove RtcEventLogImpl forward declaration from rtc_event_log.h (Closed)

Created:
3 years, 3 months ago by eladalon
Modified:
3 years, 3 months ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove RtcEventLogImpl forward declaration from rtc_event_log.h The forward delcaration is not necessary. BUG=None Review-Url: https://codereview.webrtc.org/3006213002 Cr-Commit-Position: refs/heads/master@{#19729} Committed: https://chromium.googlesource.com/external/webrtc/+/5a7dad8453956007d83187cd8a591faf46c0b6c1

Patch Set 1 #

Messages

Total messages: 9 (4 generated)
eladalon
PTAL
3 years, 3 months ago (2017-09-07 10:01:42 UTC) #2
terelius
3 years, 3 months ago (2017-09-07 14:01:26 UTC) #3
terelius
lgtm
3 years, 3 months ago (2017-09-07 14:01:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006213002/1
3 years, 3 months ago (2017-09-07 14:11:24 UTC) #6
commit-bot: I haz the power
3 years, 3 months ago (2017-09-07 15:02:40 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5a7dad8453956007d83187cd8...

Powered by Google App Engine
This is Rietveld 408576698