Move StreamConfig into its own file

Move StreamConfig into its own file

Move StreamConfig into its own file, to allow it to be seen from different RtcEvent subclasses (introduces in upcoming CL).

BUG=webrtc:8111
Review-Url: https://codereview.webrtc.org/3013523002
Cr-Commit-Position: refs/heads/master@{#19776}
Committed: https://chromium.googlesource.com/external/webrtc/+/4bb3b9c6cbc0aafcd7e9c0b385bb33ceda70ee1a

[eladalon, 2017-09-08 12:45:49]

eladalon@webrtc.org changed reviewers:
+ terelius@webrtc.org

[eladalon, 2017-09-08 12:45:50]

PTAL

[terelius, 2017-09-08 12:51:50]

https://codereview.webrtc.org/3013523002/diff/20001/webrtc/logging/rtc_event_...
File webrtc/logging/rtc_event_log/rtc_event_log.h (right):

https://codereview.webrtc.org/3013523002/diff/20001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_event_log.h:21: #include
"webrtc/logging/rtc_event_log/rtc_stream_config.h"
Do we have to include it here, or is it sufficient to forward declare?

https://codereview.webrtc.org/3013523002/diff/20001/webrtc/logging/rtc_event_...
File webrtc/logging/rtc_event_log/rtc_stream_config.h (right):

https://codereview.webrtc.org/3013523002/diff/20001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_stream_config.h:22: // the protobuf file.
The comment no longer applies.

[eladalon, 2017-09-08 13:04:16]

https://codereview.webrtc.org/3013523002/diff/20001/webrtc/logging/rtc_event_...
File webrtc/logging/rtc_event_log/rtc_event_log.h (right):

https://codereview.webrtc.org/3013523002/diff/20001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_event_log.h:21: #include
"webrtc/logging/rtc_event_log/rtc_stream_config.h"
On 2017/09/08 12:51:50, terelius wrote:
> Do we have to include it here, or is it sufficient to forward declare?

I suspect some places that are passing in objects of this type, get its
definition from here. I prefer to leave this here until later in the stack of
CLs, then change it to a forward-declaration.

https://codereview.webrtc.org/3013523002/diff/20001/webrtc/logging/rtc_event_...
File webrtc/logging/rtc_event_log/rtc_stream_config.h (right):

https://codereview.webrtc.org/3013523002/diff/20001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_stream_config.h:22: // the protobuf file.
On 2017/09/08 12:51:50, terelius wrote:
> The comment no longer applies.

Done.

[terelius, 2017-09-08 13:16:29]

lgtm with 2 nits

https://codereview.webrtc.org/3013523002/diff/20001/webrtc/logging/rtc_event_...
File webrtc/logging/rtc_event_log/rtc_event_log.h (right):

https://codereview.webrtc.org/3013523002/diff/20001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_event_log.h:21: #include
"webrtc/logging/rtc_event_log/rtc_stream_config.h"
On 2017/09/08 13:04:16, eladalon wrote:
> On 2017/09/08 12:51:50, terelius wrote:
> > Do we have to include it here, or is it sufficient to forward declare?
> 
> I suspect some places that are passing in objects of this type, get its
> definition from here. I prefer to leave this here until later in the stack of
> CLs, then change it to a forward-declaration.

Acknowledged. Please add a TODO.

https://codereview.webrtc.org/3013523002/diff/60001/webrtc/logging/rtc_event_...
File webrtc/logging/rtc_event_log/rtc_event_log.h (right):

https://codereview.webrtc.org/3013523002/diff/60001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_event_log.h:19: #include
"webrtc/api/rtpparameters.h"
I don't think this include is needed anymore.

[eladalon, 2017-09-08 13:19:57]

https://codereview.webrtc.org/3013523002/diff/20001/webrtc/logging/rtc_event_...
File webrtc/logging/rtc_event_log/rtc_event_log.h (right):

https://codereview.webrtc.org/3013523002/diff/20001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_event_log.h:21: #include
"webrtc/logging/rtc_event_log/rtc_stream_config.h"
On 2017/09/08 13:16:29, terelius wrote:
> On 2017/09/08 13:04:16, eladalon wrote:
> > On 2017/09/08 12:51:50, terelius wrote:
> > > Do we have to include it here, or is it sufficient to forward declare?
> > 
> > I suspect some places that are passing in objects of this type, get its
> > definition from here. I prefer to leave this here until later in the stack
of
> > CLs, then change it to a forward-declaration.
> 
> Acknowledged. Please add a TODO.

Done.

https://codereview.webrtc.org/3013523002/diff/60001/webrtc/logging/rtc_event_...
File webrtc/logging/rtc_event_log/rtc_event_log.h (right):

https://codereview.webrtc.org/3013523002/diff/60001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_event_log.h:19: #include
"webrtc/api/rtpparameters.h"
On 2017/09/08 13:16:29, terelius wrote:
> I don't think this include is needed anymore.

It is - RtpExtension.

[eladalon, 2017-09-08 13:23:52]

https://codereview.webrtc.org/3013523002/diff/60001/webrtc/logging/rtc_event_...
File webrtc/logging/rtc_event_log/rtc_event_log.h (right):

https://codereview.webrtc.org/3013523002/diff/60001/webrtc/logging/rtc_event_...
webrtc/logging/rtc_event_log/rtc_event_log.h:19: #include
"webrtc/api/rtpparameters.h"
On 2017/09/08 13:19:57, eladalon wrote:
> On 2017/09/08 13:16:29, terelius wrote:
> > I don't think this include is needed anymore.
> 
> It is - RtpExtension.

Oh, wrong file. Oops.

[eladalon, 2017-09-08 15:22:42]

The CQ bit was checked by eladalon@webrtc.org

[eladalon, 2017-09-08 15:22:42]

The patchset sent to the CQ was uploaded after l-g-t-m from terelius@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3013523002/#ps140001 (title:
"Rebased")

[commit-bot: I haz the power, 2017-09-08 15:22:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-08 15:30:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-08 15:30:31]

Try jobs failed on following builders:
  ios_api_framework on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...)

[eladalon, 2017-09-08 16:00:45]

The CQ bit was checked by eladalon@webrtc.org

[commit-bot: I haz the power, 2017-09-08 16:00:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-08 16:17:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-08 16:17:54]

Try jobs failed on following builders:
  ios_api_framework on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...)

[eladalon, 2017-09-08 17:07:29]

The CQ bit was checked by eladalon@webrtc.org

[commit-bot: I haz the power, 2017-09-08 17:07:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-08 17:21:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-08 17:21:46]

Try jobs failed on following builders:
  ios_api_framework on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...)

[eladalon, 2017-09-11 13:24:07]

The CQ bit was checked by eladalon@webrtc.org

[commit-bot: I haz the power, 2017-09-11 13:24:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-11 14:25:27]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1505136247419920,
"parent_rev": "b600d8794b7c6acd450623adc08173a7557e492c", "commit_rev":
"4bb3b9c6cbc0aafcd7e9c0b385bb33ceda70ee1a"}

[commit-bot: I haz the power, 2017-09-11 14:25:35]

Description was changed from

==========
Move StreamConfig into its own file

Move StreamConfig into its own file, to allow it to be seen from different
RtcEvent subclasses (introduces in upcoming CL).

BUG=webrtc:8111
==========

to

==========
Move StreamConfig into its own file

Move StreamConfig into its own file, to allow it to be seen from different
RtcEvent subclasses (introduces in upcoming CL).

BUG=webrtc:8111

Review-Url: https://codereview.webrtc.org/3013523002
Cr-Commit-Position: refs/heads/master@{#19776}
Committed:
https://chromium.googlesource.com/external/webrtc/+/4bb3b9c6cbc0aafcd7e9c0b38...
==========

[commit-bot: I haz the power, 2017-09-11 14:25:37]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/external/webrtc/+/4bb3b9c6cbc0aafcd7e9c0b38...