Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 3009413002: Reland of move deprecated CodecType methods. (Closed)

Created:
3 years, 3 months ago by kthelgason
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of move deprecated CodecType methods. (patchset #1 id:1 of https://codereview.webrtc.org/3010553002/ ) Reason for revert: Fixes have landed in chromium. Original issue's description: > Revert of Remove deprecated CodecType methods. (patchset #1 id:1 of https://codereview.webrtc.org/3009583002/ ) > > Reason for revert: > It breaks chromium FYI bots. > > E.g.: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/11615 > > Original issue's description: > > Remove deprecated CodecType methods. > > > > These are no longer needed as all clients have been updated to use the > > new methods that always return a value. > > > > BUG=None > > > > Review-Url: https://codereview.webrtc.org/3009583002 > > Cr-Commit-Position: refs/heads/master@{#19559} > > Committed: https://chromium.googlesource.com/external/webrtc/+/1a92d0de49779567241e97e50cb69d51257adcce > > TBR=magjed@webrtc.org,tommi@webrtc.org,kthelgason@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=None > > Review-Url: https://codereview.webrtc.org/3010553002 > Cr-Commit-Position: refs/heads/master@{#19563} > Committed: https://chromium.googlesource.com/external/webrtc/+/673caedc39f8fc0975fb902041c9000c271bfccf TBR=magjed@webrtc.org,tommi@webrtc.org,mbonadei@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=None Review-Url: https://codereview.webrtc.org/3009413002 Cr-Commit-Position: refs/heads/master@{#19816} Committed: https://chromium.googlesource.com/external/webrtc/+/dc80abe975e9523c9bb3eba65240538ee2478c72

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M webrtc/common_types.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/common_types.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kthelgason
Created Reland of move deprecated CodecType methods.
3 years, 3 months ago (2017-09-13 11:44:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3009413002/1
3 years, 3 months ago (2017-09-13 11:45:04 UTC) #3
commit-bot: I haz the power
3 years, 3 months ago (2017-09-13 12:16:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/dc80abe975e9523c9bb3eba65...

Powered by Google App Engine
This is Rietveld 408576698