Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 3009583002: Remove deprecated CodecType methods. (Closed)

Created:
3 years, 3 months ago by kthelgason
Modified:
3 years, 3 months ago
Reviewers:
magjed_webrtc, tommi
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove deprecated CodecType methods. These are no longer needed as all clients have been updated to use the new methods that always return a value. BUG=None Review-Url: https://codereview.webrtc.org/3009583002 Cr-Commit-Position: refs/heads/master@{#19559} Committed: https://chromium.googlesource.com/external/webrtc/+/1a92d0de49779567241e97e50cb69d51257adcce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M webrtc/common_types.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/common_types.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
kthelgason
PTAL
3 years, 3 months ago (2017-08-28 09:20:31 UTC) #6
magjed_webrtc
lgtm
3 years, 3 months ago (2017-08-28 11:54:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3009583002/1
3 years, 3 months ago (2017-08-28 12:12:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/20816)
3 years, 3 months ago (2017-08-28 12:16:41 UTC) #11
kthelgason
+tommi for OWNER approval
3 years, 3 months ago (2017-08-28 12:53:27 UTC) #13
tommi
lgtm
3 years, 3 months ago (2017-08-28 13:08:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3009583002/1
3 years, 3 months ago (2017-08-28 13:13:51 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/1a92d0de49779567241e97e50cb69d51257adcce
3 years, 3 months ago (2017-08-28 13:16:08 UTC) #19
mbonadei
3 years, 3 months ago (2017-08-28 14:16:32 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/3010553002/ by mbonadei@webrtc.org.

The reason for reverting is: It breaks chromium FYI bots.

E.g.:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/build....

Powered by Google App Engine
This is Rietveld 408576698