Android: Add helper class VideoFrameDrawer that can render VideoFrames

Android: Add helper class VideoFrameDrawer that can render VideoFrames

This CL adds a helper class VideoFrameDrawer that provides an
abstraction for rendering arbitrary video frames using OpenGL. The class
takes care of dispatching on the video buffer type and uploading
I420 data to textures.

BUG=None

Review-Url: https://codereview.webrtc.org/3008423002
Cr-Commit-Position: refs/heads/master@{#19768}
Committed: https://chromium.googlesource.com/external/webrtc/+/7cede379c7d44fcaf356f3c3fe59424cbe0dd84e

[magjed_webrtc, 2017-09-10 15:24:07]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-10 15:24:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2017-09-10 15:28:06]

Description was changed from

==========
Android: Add helper class VideoFrameDrawer that can render VideoFrames

This CL adds a helper class VideoFrameDrawer that provides an
abstraction for rendering arbitrary video frames using OpenGL. The class
takes care of dispatching on the video buffer type and uploading
I420 data to textures.

BUG=None
==========

to

==========
Android: Add helper class VideoFrameDrawer that can render VideoFrames

This CL adds a helper class VideoFrameDrawer that provides an
abstraction for rendering arbitrary video frames using OpenGL. The class
takes care of dispatching on the video buffer type and uploading
I420 data to textures.

BUG=None
==========

[magjed_webrtc, 2017-09-10 15:28:06]

magjed@webrtc.org changed reviewers:
+ sakal@webrtc.org

[magjed_webrtc, 2017-09-10 15:28:20]

Sami - please take a look.

[commit-bot: I haz the power, 2017-09-10 15:50:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-10 15:50:30]

Dry run: This issue passed the CQ dry run.

[sakal, 2017-09-11 09:05:58]

lgtm

https://codereview.webrtc.org/3008423002/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/VideoFrameDrawer.java (right):

https://codereview.webrtc.org/3008423002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/VideoFrameDrawer.java:92:
RendererCommon.drawTexture(drawer, (VideoFrame.TextureBuffer) frame.getBuffer(),
renderMatrix,
Maybe we should move RendererCommon.drawTexture to this class?

[magjed_webrtc, 2017-09-11 12:26:09]

The CQ bit was checked by magjed@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-11 12:26:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2017-09-11 12:45:44]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2017-09-11 12:45:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sakal@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3008423002/#ps40001 (title:
"similarity=10")

[magjed_webrtc, 2017-09-11 12:45:48]

https://codereview.webrtc.org/3008423002/diff/1/webrtc/sdk/android/api/org/we...
File webrtc/sdk/android/api/org/webrtc/VideoFrameDrawer.java (right):

https://codereview.webrtc.org/3008423002/diff/1/webrtc/sdk/android/api/org/we...
webrtc/sdk/android/api/org/webrtc/VideoFrameDrawer.java:92:
RendererCommon.drawTexture(drawer, (VideoFrame.TextureBuffer) frame.getBuffer(),
renderMatrix,
On 2017/09/11 09:05:58, sakal wrote:
> Maybe we should move RendererCommon.drawTexture to this class?

Done, I also moved YuvUploader.

[commit-bot: I haz the power, 2017-09-11 12:45:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-11 13:12:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1505133944101810,
"parent_rev": "bc378479787930b511b151b278318516492bc9fc", "commit_rev":
"7cede379c7d44fcaf356f3c3fe59424cbe0dd84e"}

[commit-bot: I haz the power, 2017-09-11 13:12:14]

Description was changed from

==========
Android: Add helper class VideoFrameDrawer that can render VideoFrames

This CL adds a helper class VideoFrameDrawer that provides an
abstraction for rendering arbitrary video frames using OpenGL. The class
takes care of dispatching on the video buffer type and uploading
I420 data to textures.

BUG=None
==========

to

==========
Android: Add helper class VideoFrameDrawer that can render VideoFrames

This CL adds a helper class VideoFrameDrawer that provides an
abstraction for rendering arbitrary video frames using OpenGL. The class
takes care of dispatching on the video buffer type and uploading
I420 data to textures.

BUG=None

Review-Url: https://codereview.webrtc.org/3008423002
Cr-Commit-Position: refs/heads/master@{#19768}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7cede379c7d44fcaf356f3c3f...
==========

[commit-bot: I haz the power, 2017-09-11 13:12:15]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/7cede379c7d44fcaf356f3c3f...