Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 3004393002: Rename thread annotation macros to have RTC prefix for syncrhonization primitives. (Closed)

Created:
3 years, 3 months ago by danilchap
Modified:
3 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, fengyue_agora.io, zhengzhonghou_agora.io, henrika_webrtc, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename thread annotation macros to have RTC prefix for syncrhonization primitives. other macros (e.g. GUARDED_BY) rename postpone to followup CL since it touches codebase wider BUG=webrtc:8198 Review-Url: https://codereview.webrtc.org/3004393002 Cr-Commit-Position: refs/heads/master@{#19701} Committed: https://chromium.googlesource.com/external/webrtc/+/9a2d2dd973ea33ba551db09257441c7f6943bfe4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -138 lines) Patch
M webrtc/modules/audio_device/linux/audio_device_alsa_linux.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_pulse_linux.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/rtc_base/criticalsection.h View 4 chunks +16 lines, -13 lines 0 comments Download
M webrtc/rtc_base/criticalsection.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/rtc_base/criticalsection_unittest.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M webrtc/rtc_base/messagequeue.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/rtc_base/race_checker.h View 2 chunks +9 lines, -9 lines 0 comments Download
M webrtc/rtc_base/sequenced_task_checker.h View 3 chunks +10 lines, -9 lines 0 comments Download
M webrtc/rtc_base/signalthread.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/rtc_base/task_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/thread.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/rtc_base/thread_annotations.h View 6 chunks +25 lines, -47 lines 0 comments Download
M webrtc/rtc_base/thread_annotations_unittest.cc View 3 chunks +15 lines, -13 lines 0 comments Download
M webrtc/rtc_base/thread_checker.h View 2 chunks +8 lines, -10 lines 0 comments Download
M webrtc/system_wrappers/include/rw_lock_wrapper.h View 1 chunk +11 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
danilchap
3 years, 3 months ago (2017-09-05 13:42:53 UTC) #3
kwiberg-webrtc
lgtm
3 years, 3 months ago (2017-09-05 20:23:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3004393002/1
3 years, 3 months ago (2017-09-06 07:32:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/9a2d2dd973ea33ba551db09257441c7f6943bfe4
3 years, 3 months ago (2017-09-06 08:19:11 UTC) #9
danilchap
3 years, 3 months ago (2017-09-06 08:38:19 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/3008193002/ by danilchap@webrtc.org.

The reason for reverting is: Breaks chromium bots.

Powered by Google App Engine
This is Rietveld 408576698