Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1680)

Side by Side Diff: webrtc/rtc_base/thread_annotations.h

Issue 3004393002: Rename thread annotation macros to have RTC prefix for syncrhonization primitives. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/rtc_base/thread.h ('k') | webrtc/rtc_base/thread_annotations_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // 1 //
2 // Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 // Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 // 3 //
4 // Use of this source code is governed by a BSD-style license 4 // Use of this source code is governed by a BSD-style license
5 // that can be found in the LICENSE file in the root of the source 5 // that can be found in the LICENSE file in the root of the source
6 // tree. An additional intellectual property rights grant can be found 6 // tree. An additional intellectual property rights grant can be found
7 // in the file PATENTS. All contributing project authors may 7 // in the file PATENTS. All contributing project authors may
8 // be found in the AUTHORS file in the root of the source tree. 8 // be found in the AUTHORS file in the root of the source tree.
9 // 9 //
10 // Borrowed from 10 // Borrowed from
11 // https://code.google.com/p/gperftools/source/browse/src/base/thread_annotation s.h 11 // https://code.google.com/p/gperftools/source/browse/src/base/thread_annotation s.h
12 // but adapted for clang attributes instead of the gcc. 12 // but adapted for clang attributes instead of the gcc.
13 // 13 //
14 // This header file contains the macro definitions for thread safety 14 // This header file contains the macro definitions for thread safety
15 // annotations that allow the developers to document the locking policies 15 // annotations that allow the developers to document the locking policies
16 // of their multi-threaded code. The annotations can also help program 16 // of their multi-threaded code. The annotations can also help program
17 // analysis tools to identify potential thread safety issues. 17 // analysis tools to identify potential thread safety issues.
18 18
19 #ifndef WEBRTC_RTC_BASE_THREAD_ANNOTATIONS_H_ 19 #ifndef WEBRTC_RTC_BASE_THREAD_ANNOTATIONS_H_
20 #define WEBRTC_RTC_BASE_THREAD_ANNOTATIONS_H_ 20 #define WEBRTC_RTC_BASE_THREAD_ANNOTATIONS_H_
21 21
22 #if defined(__clang__) && (!defined(SWIG)) 22 #if defined(__clang__) && (!defined(SWIG))
23 #define THREAD_ANNOTATION_ATTRIBUTE__(x) __attribute__((x)) 23 #define RTC_THREAD_ANNOTATION_ATTRIBUTE__(x) __attribute__((x))
24 #else 24 #else
25 #define THREAD_ANNOTATION_ATTRIBUTE__(x) // no-op 25 #define RTC_THREAD_ANNOTATION_ATTRIBUTE__(x) // no-op
26 #endif 26 #endif
27 27
28 // Document if a shared variable/field needs to be protected by a lock. 28 // Document if a shared variable/field needs to be protected by a lock.
29 // GUARDED_BY allows the user to specify a particular lock that should be 29 // GUARDED_BY allows the user to specify a particular lock that should be
30 // held when accessing the annotated variable, while GUARDED_VAR only 30 // held when accessing the annotated variable, while GUARDED_VAR only
31 // indicates a shared variable should be guarded (by any lock). GUARDED_VAR 31 // indicates a shared variable should be guarded (by any lock). GUARDED_VAR
32 // is primarily used when the client cannot express the name of the lock. 32 // is primarily used when the client cannot express the name of the lock.
33 #if !defined(GUARDED_BY) 33 #if !defined(GUARDED_BY)
34 #define GUARDED_BY(x) THREAD_ANNOTATION_ATTRIBUTE__(guarded_by(x)) 34 #define GUARDED_BY(x) RTC_THREAD_ANNOTATION_ATTRIBUTE__(guarded_by(x))
35 #endif 35 #endif
36 #if !defined(GUARDED_VAR) 36 #define RTC_GUARDED_VAR RTC_THREAD_ANNOTATION_ATTRIBUTE__(guarded_var)
37 #define GUARDED_VAR THREAD_ANNOTATION_ATTRIBUTE__(guarded_var)
38 #endif
39 37
40 // Document if the memory location pointed to by a pointer should be guarded 38 // Document if the memory location pointed to by a pointer should be guarded
41 // by a lock when dereferencing the pointer. Similar to GUARDED_VAR, 39 // by a lock when dereferencing the pointer. Similar to GUARDED_VAR,
42 // PT_GUARDED_VAR is primarily used when the client cannot express the name 40 // PT_GUARDED_VAR is primarily used when the client cannot express the name
43 // of the lock. Note that a pointer variable to a shared memory location 41 // of the lock. Note that a pointer variable to a shared memory location
44 // could itself be a shared variable. For example, if a shared global pointer 42 // could itself be a shared variable. For example, if a shared global pointer
45 // q, which is guarded by mu1, points to a shared memory location that is 43 // q, which is guarded by mu1, points to a shared memory location that is
46 // guarded by mu2, q should be annotated as follows: 44 // guarded by mu2, q should be annotated as follows:
47 // int *q GUARDED_BY(mu1) PT_GUARDED_BY(mu2); 45 // int *q GUARDED_BY(mu1) PT_GUARDED_BY(mu2);
48 #if !defined(PT_GUARDED_BY) 46 #define RTC_PT_GUARDED_BY(x) RTC_THREAD_ANNOTATION_ATTRIBUTE__(pt_guarded_by(x))
49 #define PT_GUARDED_BY(x) THREAD_ANNOTATION_ATTRIBUTE__(pt_guarded_by(x)) 47 #define RTC_PT_GUARDED_VAR RTC_THREAD_ANNOTATION_ATTRIBUTE__(pt_guarded_var)
50 #endif
51 #if !defined(PT_GUARDED_VAR)
52 #define PT_GUARDED_VAR THREAD_ANNOTATION_ATTRIBUTE__(pt_guarded_var)
53 #endif
54 48
55 // Document the acquisition order between locks that can be held 49 // Document the acquisition order between locks that can be held
56 // simultaneously by a thread. For any two locks that need to be annotated 50 // simultaneously by a thread. For any two locks that need to be annotated
57 // to establish an acquisition order, only one of them needs the annotation. 51 // to establish an acquisition order, only one of them needs the annotation.
58 // (i.e. You don't have to annotate both locks with both ACQUIRED_AFTER 52 // (i.e. You don't have to annotate both locks with both ACQUIRED_AFTER
59 // and ACQUIRED_BEFORE.) 53 // and ACQUIRED_BEFORE.)
60 #if !defined(ACQUIRED_AFTER) 54 #if !defined(ACQUIRED_AFTER)
61 #define ACQUIRED_AFTER(x) THREAD_ANNOTATION_ATTRIBUTE__(acquired_after(x)) 55 #define ACQUIRED_AFTER(x) RTC_THREAD_ANNOTATION_ATTRIBUTE__(acquired_after(x))
62 #endif 56 #endif
63 #if !defined(ACQUIRED_BEFORE) 57 #if !defined(ACQUIRED_BEFORE)
64 #define ACQUIRED_BEFORE(x) THREAD_ANNOTATION_ATTRIBUTE__(acquired_before(x)) 58 #define ACQUIRED_BEFORE(x) RTC_THREAD_ANNOTATION_ATTRIBUTE__(acquired_before(x))
65 #endif 59 #endif
66 60
67 // The following three annotations document the lock requirements for 61 // The following three annotations document the lock requirements for
68 // functions/methods. 62 // functions/methods.
69 63
70 // Document if a function expects certain locks to be held before it is called 64 // Document if a function expects certain locks to be held before it is called
71 #if !defined(EXCLUSIVE_LOCKS_REQUIRED) 65 #if !defined(EXCLUSIVE_LOCKS_REQUIRED)
72 #define EXCLUSIVE_LOCKS_REQUIRED(...) \ 66 #define EXCLUSIVE_LOCKS_REQUIRED(...) \
73 THREAD_ANNOTATION_ATTRIBUTE__(exclusive_locks_required(__VA_ARGS__)) 67 RTC_THREAD_ANNOTATION_ATTRIBUTE__(exclusive_locks_required(__VA_ARGS__))
74 #endif 68 #endif
75 69
76 #if !defined(SHARED_LOCKS_REQUIRED) 70 #if !defined(SHARED_LOCKS_REQUIRED)
77 #define SHARED_LOCKS_REQUIRED(...) \ 71 #define SHARED_LOCKS_REQUIRED(...) \
78 THREAD_ANNOTATION_ATTRIBUTE__(shared_locks_required(__VA_ARGS__)) 72 RTC_THREAD_ANNOTATION_ATTRIBUTE__(shared_locks_required(__VA_ARGS__))
79 #endif 73 #endif
80 74
81 // Document the locks acquired in the body of the function. These locks 75 // Document the locks acquired in the body of the function. These locks
82 // cannot be held when calling this function (as google3's Mutex locks are 76 // cannot be held when calling this function (as google3's Mutex locks are
83 // non-reentrant). 77 // non-reentrant).
84 #if !defined(LOCKS_EXCLUDED) 78 #if !defined(LOCKS_EXCLUDED)
85 #define LOCKS_EXCLUDED(...) \ 79 #define LOCKS_EXCLUDED(...) \
86 THREAD_ANNOTATION_ATTRIBUTE__(locks_excluded(__VA_ARGS__)) 80 RTC_THREAD_ANNOTATION_ATTRIBUTE__(locks_excluded(__VA_ARGS__))
87 #endif 81 #endif
88 82
89 // Document the lock the annotated function returns without acquiring it. 83 // Document the lock the annotated function returns without acquiring it.
90 #if !defined(LOCK_RETURNED) 84 #define RTC_LOCK_RETURNED(x) RTC_THREAD_ANNOTATION_ATTRIBUTE__(lock_returned(x))
91 #define LOCK_RETURNED(x) THREAD_ANNOTATION_ATTRIBUTE__(lock_returned(x))
92 #endif
93 85
94 // Document if a class/type is a lockable type (such as the Mutex class). 86 // Document if a class/type is a lockable type (such as the Mutex class).
95 #if !defined(LOCKABLE) 87 #define RTC_LOCKABLE RTC_THREAD_ANNOTATION_ATTRIBUTE__(lockable)
96 #define LOCKABLE THREAD_ANNOTATION_ATTRIBUTE__(lockable)
97 #endif
98 88
99 // Document if a class is a scoped lockable type (such as the MutexLock class). 89 // Document if a class is a scoped lockable type (such as the MutexLock class).
100 #if !defined(SCOPED_LOCKABLE) 90 #define RTC_SCOPED_LOCKABLE RTC_THREAD_ANNOTATION_ATTRIBUTE__(scoped_lockable)
101 #define SCOPED_LOCKABLE THREAD_ANNOTATION_ATTRIBUTE__(scoped_lockable)
102 #endif
103 91
104 // The following annotations specify lock and unlock primitives. 92 // The following annotations specify lock and unlock primitives.
105 #if !defined(EXCLUSIVE_LOCK_FUNCTION) 93 #define RTC_EXCLUSIVE_LOCK_FUNCTION(...) \
106 #define EXCLUSIVE_LOCK_FUNCTION(...) \ 94 RTC_THREAD_ANNOTATION_ATTRIBUTE__(exclusive_lock_function(__VA_ARGS__))
107 THREAD_ANNOTATION_ATTRIBUTE__(exclusive_lock_function(__VA_ARGS__))
108 #endif
109 95
110 #if !defined(SHARED_LOCK_FUNCTION) 96 #define RTC_SHARED_LOCK_FUNCTION(...) \
111 #define SHARED_LOCK_FUNCTION(...) \ 97 RTC_THREAD_ANNOTATION_ATTRIBUTE__(shared_lock_function(__VA_ARGS__))
112 THREAD_ANNOTATION_ATTRIBUTE__(shared_lock_function(__VA_ARGS__))
113 #endif
114 98
115 #if !defined(EXCLUSIVE_TRYLOCK_FUNCTION) 99 #define RTC_EXCLUSIVE_TRYLOCK_FUNCTION(...) \
116 #define EXCLUSIVE_TRYLOCK_FUNCTION(...) \ 100 RTC_THREAD_ANNOTATION_ATTRIBUTE__(exclusive_trylock_function(__VA_ARGS__))
117 THREAD_ANNOTATION_ATTRIBUTE__(exclusive_trylock_function(__VA_ARGS__))
118 #endif
119 101
120 #if !defined(SHARED_TRYLOCK_FUNCTION) 102 #define RTC_SHARED_TRYLOCK_FUNCTION(...) \
121 #define SHARED_TRYLOCK_FUNCTION(...) \ 103 RTC_THREAD_ANNOTATION_ATTRIBUTE__(shared_trylock_function(__VA_ARGS__))
122 THREAD_ANNOTATION_ATTRIBUTE__(shared_trylock_function(__VA_ARGS__))
123 #endif
124 104
125 #if !defined(UNLOCK_FUNCTION) 105 #define RTC_UNLOCK_FUNCTION(...) \
126 #define UNLOCK_FUNCTION(...) \ 106 RTC_THREAD_ANNOTATION_ATTRIBUTE__(unlock_function(__VA_ARGS__))
127 THREAD_ANNOTATION_ATTRIBUTE__(unlock_function(__VA_ARGS__))
128 #endif
129 107
130 // An escape hatch for thread safety analysis to ignore the annotated function. 108 // An escape hatch for thread safety analysis to ignore the annotated function.
131 #if !defined(NO_THREAD_SAFETY_ANALYSIS) 109 #if !defined(NO_THREAD_SAFETY_ANALYSIS)
132 #define NO_THREAD_SAFETY_ANALYSIS \ 110 #define NO_THREAD_SAFETY_ANALYSIS \
133 THREAD_ANNOTATION_ATTRIBUTE__(no_thread_safety_analysis) 111 RTC_THREAD_ANNOTATION_ATTRIBUTE__(no_thread_safety_analysis)
134 #endif 112 #endif
135 113
136 #endif // WEBRTC_RTC_BASE_THREAD_ANNOTATIONS_H_ 114 #endif // WEBRTC_RTC_BASE_THREAD_ANNOTATIONS_H_
OLDNEW
« no previous file with comments | « webrtc/rtc_base/thread.h ('k') | webrtc/rtc_base/thread_annotations_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698