Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Side by Side Diff: webrtc/rtc_base/race_checker.h

Issue 3004393002: Rename thread annotation macros to have RTC prefix for syncrhonization primitives. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/rtc_base/messagequeue.cc ('k') | webrtc/rtc_base/sequenced_task_checker.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_RTC_BASE_RACE_CHECKER_H_ 11 #ifndef WEBRTC_RTC_BASE_RACE_CHECKER_H_
12 #define WEBRTC_RTC_BASE_RACE_CHECKER_H_ 12 #define WEBRTC_RTC_BASE_RACE_CHECKER_H_
13 13
14 #include "webrtc/rtc_base/checks.h" 14 #include "webrtc/rtc_base/checks.h"
15 #include "webrtc/rtc_base/platform_thread.h" 15 #include "webrtc/rtc_base/platform_thread.h"
16 #include "webrtc/rtc_base/thread_annotations.h" 16 #include "webrtc/rtc_base/thread_annotations.h"
17 17
18 namespace rtc { 18 namespace rtc {
19 19
20 namespace internal { 20 namespace internal {
21 class RaceCheckerScope; 21 class RaceCheckerScope;
22 } // namespace internal 22 } // namespace internal
23 23
24 // Best-effort race-checking implementation. This primitive uses no 24 // Best-effort race-checking implementation. This primitive uses no
25 // synchronization at all to be as-fast-as-possible in the non-racy case. 25 // synchronization at all to be as-fast-as-possible in the non-racy case.
26 class LOCKABLE RaceChecker { 26 class RTC_LOCKABLE RaceChecker {
27 public: 27 public:
28 friend class internal::RaceCheckerScope; 28 friend class internal::RaceCheckerScope;
29 RaceChecker(); 29 RaceChecker();
30 30
31 private: 31 private:
32 bool Acquire() const EXCLUSIVE_LOCK_FUNCTION(); 32 bool Acquire() const RTC_EXCLUSIVE_LOCK_FUNCTION();
33 void Release() const UNLOCK_FUNCTION(); 33 void Release() const RTC_UNLOCK_FUNCTION();
34 34
35 // Volatile to prevent code being optimized away in Acquire()/Release(). 35 // Volatile to prevent code being optimized away in Acquire()/Release().
36 mutable volatile int access_count_ = 0; 36 mutable volatile int access_count_ = 0;
37 mutable volatile PlatformThreadRef accessing_thread_; 37 mutable volatile PlatformThreadRef accessing_thread_;
38 }; 38 };
39 39
40 namespace internal { 40 namespace internal {
41 class SCOPED_LOCKABLE RaceCheckerScope { 41 class RTC_SCOPED_LOCKABLE RaceCheckerScope {
42 public: 42 public:
43 explicit RaceCheckerScope(const RaceChecker* race_checker) 43 explicit RaceCheckerScope(const RaceChecker* race_checker)
44 EXCLUSIVE_LOCK_FUNCTION(race_checker); 44 RTC_EXCLUSIVE_LOCK_FUNCTION(race_checker);
45 45
46 bool RaceDetected() const; 46 bool RaceDetected() const;
47 ~RaceCheckerScope() UNLOCK_FUNCTION(); 47 ~RaceCheckerScope() RTC_UNLOCK_FUNCTION();
48 48
49 private: 49 private:
50 const RaceChecker* const race_checker_; 50 const RaceChecker* const race_checker_;
51 const bool race_check_ok_; 51 const bool race_check_ok_;
52 }; 52 };
53 53
54 class SCOPED_LOCKABLE RaceCheckerScopeDoNothing { 54 class RTC_SCOPED_LOCKABLE RaceCheckerScopeDoNothing {
55 public: 55 public:
56 explicit RaceCheckerScopeDoNothing(const RaceChecker* race_checker) 56 explicit RaceCheckerScopeDoNothing(const RaceChecker* race_checker)
57 EXCLUSIVE_LOCK_FUNCTION(race_checker) {} 57 RTC_EXCLUSIVE_LOCK_FUNCTION(race_checker) {}
58 58
59 ~RaceCheckerScopeDoNothing() UNLOCK_FUNCTION() {} 59 ~RaceCheckerScopeDoNothing() RTC_UNLOCK_FUNCTION() {}
60 }; 60 };
61 61
62 } // namespace internal 62 } // namespace internal
63 } // namespace rtc 63 } // namespace rtc
64 64
65 #define RTC_CHECK_RUNS_SERIALIZED(x) \ 65 #define RTC_CHECK_RUNS_SERIALIZED(x) \
66 rtc::internal::RaceCheckerScope race_checker(x); \ 66 rtc::internal::RaceCheckerScope race_checker(x); \
67 RTC_CHECK(!race_checker.RaceDetected()) 67 RTC_CHECK(!race_checker.RaceDetected())
68 68
69 #if RTC_DCHECK_IS_ON 69 #if RTC_DCHECK_IS_ON
70 #define RTC_DCHECK_RUNS_SERIALIZED(x) \ 70 #define RTC_DCHECK_RUNS_SERIALIZED(x) \
71 rtc::internal::RaceCheckerScope race_checker(x); \ 71 rtc::internal::RaceCheckerScope race_checker(x); \
72 RTC_DCHECK(!race_checker.RaceDetected()) 72 RTC_DCHECK(!race_checker.RaceDetected())
73 #else 73 #else
74 #define RTC_DCHECK_RUNS_SERIALIZED(x) \ 74 #define RTC_DCHECK_RUNS_SERIALIZED(x) \
75 rtc::internal::RaceCheckerScopeDoNothing race_checker(x) 75 rtc::internal::RaceCheckerScopeDoNothing race_checker(x)
76 #endif 76 #endif
77 77
78 #endif // WEBRTC_RTC_BASE_RACE_CHECKER_H_ 78 #endif // WEBRTC_RTC_BASE_RACE_CHECKER_H_
OLDNEW
« no previous file with comments | « webrtc/rtc_base/messagequeue.cc ('k') | webrtc/rtc_base/sequenced_task_checker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698