Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: webrtc/rtc_base/sequenced_task_checker.h

Issue 3004393002: Rename thread annotation macros to have RTC prefix for syncrhonization primitives. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/rtc_base/race_checker.h ('k') | webrtc/rtc_base/signalthread.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_RTC_BASE_SEQUENCED_TASK_CHECKER_H_ 11 #ifndef WEBRTC_RTC_BASE_SEQUENCED_TASK_CHECKER_H_
12 #define WEBRTC_RTC_BASE_SEQUENCED_TASK_CHECKER_H_ 12 #define WEBRTC_RTC_BASE_SEQUENCED_TASK_CHECKER_H_
13 13
14 // Apart from debug builds, we also enable the sequence checker in 14 // Apart from debug builds, we also enable the sequence checker in
15 // builds with RTC_DCHECK_IS_ON so that trybots and waterfall bots 15 // builds with RTC_DCHECK_IS_ON so that trybots and waterfall bots
16 // with this define will get the same level of checking as debug bots. 16 // with this define will get the same level of checking as debug bots.
17 #define ENABLE_SEQUENCED_TASK_CHECKER RTC_DCHECK_IS_ON 17 #define RTC_ENABLE_SEQUENCED_TASK_CHECKER RTC_DCHECK_IS_ON
18 18
19 #include "webrtc/rtc_base/checks.h" 19 #include "webrtc/rtc_base/checks.h"
20 #include "webrtc/rtc_base/constructormagic.h" 20 #include "webrtc/rtc_base/constructormagic.h"
21 #include "webrtc/rtc_base/sequenced_task_checker_impl.h" 21 #include "webrtc/rtc_base/sequenced_task_checker_impl.h"
22 #include "webrtc/rtc_base/thread_annotations.h" 22 #include "webrtc/rtc_base/thread_annotations.h"
23 23
24 namespace rtc { 24 namespace rtc {
25 25
26 // Do nothing implementation, for use in release mode. 26 // Do nothing implementation, for use in release mode.
27 // 27 //
(...skipping 18 matching lines...) Expand all
46 // void Foo() { 46 // void Foo() {
47 // RTC_DCHECK(sequence_checker_.CalledSequentially()); 47 // RTC_DCHECK(sequence_checker_.CalledSequentially());
48 // ... (do stuff) ... 48 // ... (do stuff) ...
49 // } 49 // }
50 // 50 //
51 // private: 51 // private:
52 // SequencedTaskChecker sequence_checker_; 52 // SequencedTaskChecker sequence_checker_;
53 // } 53 // }
54 // 54 //
55 // In Release mode, CalledOnValidThread will always return true. 55 // In Release mode, CalledOnValidThread will always return true.
56 #if ENABLE_SEQUENCED_TASK_CHECKER 56 #if RTC_ENABLE_SEQUENCED_TASK_CHECKER
57 class LOCKABLE SequencedTaskChecker : public SequencedTaskCheckerImpl {}; 57 class RTC_LOCKABLE SequencedTaskChecker : public SequencedTaskCheckerImpl {};
58 #else 58 #else
59 class LOCKABLE SequencedTaskChecker : public SequencedTaskCheckerDoNothing {}; 59 class RTC_LOCKABLE SequencedTaskChecker : public SequencedTaskCheckerDoNothing {
60 #endif // ENABLE_SEQUENCED_TASK_CHECKER_H_ 60 };
61 #endif // RTC_ENABLE_SEQUENCED_TASK_CHECKER_H_
61 62
62 namespace internal { 63 namespace internal {
63 class SCOPED_LOCKABLE SequencedTaskCheckerScope { 64 class RTC_SCOPED_LOCKABLE SequencedTaskCheckerScope {
64 public: 65 public:
65 explicit SequencedTaskCheckerScope(const SequencedTaskChecker* checker) 66 explicit SequencedTaskCheckerScope(const SequencedTaskChecker* checker)
66 EXCLUSIVE_LOCK_FUNCTION(checker); 67 RTC_EXCLUSIVE_LOCK_FUNCTION(checker);
67 ~SequencedTaskCheckerScope() UNLOCK_FUNCTION(); 68 ~SequencedTaskCheckerScope() RTC_UNLOCK_FUNCTION();
68 }; 69 };
69 70
70 } // namespace internal 71 } // namespace internal
71 72
72 #define RTC_DCHECK_CALLED_SEQUENTIALLY(x) \ 73 #define RTC_DCHECK_CALLED_SEQUENTIALLY(x) \
73 rtc::internal::SequencedTaskCheckerScope checker(x) 74 rtc::internal::SequencedTaskCheckerScope checker(x)
74 75
75 #undef ENABLE_SEQUENCED_TASK_CHECKER 76 #undef RTC_ENABLE_SEQUENCED_TASK_CHECKER
76 77
77 } // namespace rtc 78 } // namespace rtc
78 #endif // WEBRTC_RTC_BASE_SEQUENCED_TASK_CHECKER_H_ 79 #endif // WEBRTC_RTC_BASE_SEQUENCED_TASK_CHECKER_H_
OLDNEW
« no previous file with comments | « webrtc/rtc_base/race_checker.h ('k') | webrtc/rtc_base/signalthread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698