Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 3002593002: Fix incorrect InterframeDelayMaxInMs histogram metrics (Closed)

Created:
3 years, 4 months ago by sprang_webrtc
Modified:
3 years, 4 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman, ilnik
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix incorrect InterframeDelayMaxInMs histogram metrics Two bugs: 1) The max value should only be reported if the average is also reported. Otherwise the max might become lower than average. (On average). 2) When reporting that max value, actually use the max value. BUG=webrtc:7420 Review-Url: https://codereview.webrtc.org/3002593002 Cr-Commit-Position: refs/heads/master@{#19352} Committed: https://chromium.googlesource.com/external/webrtc/+/892dab52b6436ce00f508726729eded75a25503d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -17 lines) Patch
M webrtc/video/receive_statistics_proxy.cc View 2 chunks +8 lines, -16 lines 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 2 chunks +62 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
sprang_webrtc
3 years, 4 months ago (2017-08-14 15:33:02 UTC) #2
philipel
lgtm
3 years, 4 months ago (2017-08-15 10:37:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3002593002/1
3 years, 4 months ago (2017-08-15 11:07:02 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-15 12:00:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/892dab52b6436ce00f5087267...

Powered by Google App Engine
This is Rietveld 408576698