Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: webrtc/video/receive_statistics_proxy.cc

Issue 3002593002: Fix incorrect InterframeDelayMaxInMs histogram metrics (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/video/receive_statistics_proxy_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/receive_statistics_proxy.cc
diff --git a/webrtc/video/receive_statistics_proxy.cc b/webrtc/video/receive_statistics_proxy.cc
index 4673707cd95b10654f3f344bccebc9098c3bf122..7852a059134c47e17a198612385afd0ed35d2fa2 100644
--- a/webrtc/video/receive_statistics_proxy.cc
+++ b/webrtc/video/receive_statistics_proxy.cc
@@ -216,6 +216,11 @@ void ReceiveStatisticsProxy::UpdateHistograms() {
if (interframe_delay_ms_screenshare != -1) {
RTC_HISTOGRAM_COUNTS_10000("WebRTC.Video.Screenshare.InterframeDelayInMs",
interframe_delay_ms_screenshare);
+ RTC_DCHECK_GE(interframe_delay_max_ms_screenshare_,
+ interframe_delay_ms_screenshare);
+ RTC_HISTOGRAM_COUNTS_10000(
+ "WebRTC.Video.Screenshare.InterframeDelayMaxInMs",
+ interframe_delay_max_ms_screenshare_);
}
int interframe_delay_ms_video =
@@ -223,24 +228,11 @@ void ReceiveStatisticsProxy::UpdateHistograms() {
if (interframe_delay_ms_video != -1) {
RTC_HISTOGRAM_COUNTS_10000("WebRTC.Video.InterframeDelayInMs",
interframe_delay_ms_video);
+ RTC_DCHECK_GE(interframe_delay_max_ms_video_, interframe_delay_ms_video);
+ RTC_HISTOGRAM_COUNTS_10000("WebRTC.Video.InterframeDelayMaxInMs",
+ interframe_delay_max_ms_video_);
}
- int interframe_delay_max_ms_screenshare =
- interframe_delay_max_ms_screenshare_;
- if (interframe_delay_max_ms_screenshare != -1) {
- RTC_HISTOGRAM_COUNTS_10000(
- "WebRTC.Video.Screenshare.InterframeDelayMaxInMs",
- interframe_delay_ms_screenshare);
- }
-
- int interframe_delay_max_ms_video = interframe_delay_max_ms_video_;
- if (interframe_delay_max_ms_video != -1) {
- RTC_HISTOGRAM_COUNTS_10000(
- "WebRTC.Video.InterframeDelayMaxInMs",
- interframe_delay_ms_video);
- }
-
-
StreamDataCounters rtp = stats_.rtp_stats;
StreamDataCounters rtx;
for (auto it : rtx_stats_)
« no previous file with comments | « no previous file | webrtc/video/receive_statistics_proxy_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698