Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: webrtc/video/receive_statistics_proxy.cc

Issue 3002593002: Fix incorrect InterframeDelayMaxInMs histogram metrics (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/video/receive_statistics_proxy_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 if (e2e_delay_max_ms_screenshare != -1) { 209 if (e2e_delay_max_ms_screenshare != -1) {
210 RTC_HISTOGRAM_COUNTS_100000("WebRTC.Video.Screenshare.EndToEndDelayMaxInMs", 210 RTC_HISTOGRAM_COUNTS_100000("WebRTC.Video.Screenshare.EndToEndDelayMaxInMs",
211 e2e_delay_max_ms_screenshare); 211 e2e_delay_max_ms_screenshare);
212 } 212 }
213 213
214 int interframe_delay_ms_screenshare = 214 int interframe_delay_ms_screenshare =
215 interframe_delay_counter_screenshare_.Avg(kMinRequiredSamples); 215 interframe_delay_counter_screenshare_.Avg(kMinRequiredSamples);
216 if (interframe_delay_ms_screenshare != -1) { 216 if (interframe_delay_ms_screenshare != -1) {
217 RTC_HISTOGRAM_COUNTS_10000("WebRTC.Video.Screenshare.InterframeDelayInMs", 217 RTC_HISTOGRAM_COUNTS_10000("WebRTC.Video.Screenshare.InterframeDelayInMs",
218 interframe_delay_ms_screenshare); 218 interframe_delay_ms_screenshare);
219 RTC_DCHECK_GE(interframe_delay_max_ms_screenshare_,
220 interframe_delay_ms_screenshare);
221 RTC_HISTOGRAM_COUNTS_10000(
222 "WebRTC.Video.Screenshare.InterframeDelayMaxInMs",
223 interframe_delay_max_ms_screenshare_);
219 } 224 }
220 225
221 int interframe_delay_ms_video = 226 int interframe_delay_ms_video =
222 interframe_delay_counter_video_.Avg(kMinRequiredSamples); 227 interframe_delay_counter_video_.Avg(kMinRequiredSamples);
223 if (interframe_delay_ms_video != -1) { 228 if (interframe_delay_ms_video != -1) {
224 RTC_HISTOGRAM_COUNTS_10000("WebRTC.Video.InterframeDelayInMs", 229 RTC_HISTOGRAM_COUNTS_10000("WebRTC.Video.InterframeDelayInMs",
225 interframe_delay_ms_video); 230 interframe_delay_ms_video);
231 RTC_DCHECK_GE(interframe_delay_max_ms_video_, interframe_delay_ms_video);
232 RTC_HISTOGRAM_COUNTS_10000("WebRTC.Video.InterframeDelayMaxInMs",
233 interframe_delay_max_ms_video_);
226 } 234 }
227 235
228 int interframe_delay_max_ms_screenshare =
229 interframe_delay_max_ms_screenshare_;
230 if (interframe_delay_max_ms_screenshare != -1) {
231 RTC_HISTOGRAM_COUNTS_10000(
232 "WebRTC.Video.Screenshare.InterframeDelayMaxInMs",
233 interframe_delay_ms_screenshare);
234 }
235
236 int interframe_delay_max_ms_video = interframe_delay_max_ms_video_;
237 if (interframe_delay_max_ms_video != -1) {
238 RTC_HISTOGRAM_COUNTS_10000(
239 "WebRTC.Video.InterframeDelayMaxInMs",
240 interframe_delay_ms_video);
241 }
242
243
244 StreamDataCounters rtp = stats_.rtp_stats; 236 StreamDataCounters rtp = stats_.rtp_stats;
245 StreamDataCounters rtx; 237 StreamDataCounters rtx;
246 for (auto it : rtx_stats_) 238 for (auto it : rtx_stats_)
247 rtx.Add(it.second); 239 rtx.Add(it.second);
248 StreamDataCounters rtp_rtx = rtp; 240 StreamDataCounters rtp_rtx = rtp;
249 rtp_rtx.Add(rtx); 241 rtp_rtx.Add(rtx);
250 int64_t elapsed_sec = 242 int64_t elapsed_sec =
251 rtp_rtx.TimeSinceFirstPacketInMs(clock_->TimeInMilliseconds()) / 1000; 243 rtp_rtx.TimeSinceFirstPacketInMs(clock_->TimeInMilliseconds()) / 1000;
252 if (elapsed_sec >= metrics::kMinRunTimeInSeconds) { 244 if (elapsed_sec >= metrics::kMinRunTimeInSeconds) {
253 RTC_HISTOGRAM_COUNTS_10000( 245 RTC_HISTOGRAM_COUNTS_10000(
(...skipping 419 matching lines...) Expand 10 before | Expand all | Expand 10 after
673 sum = 0; 665 sum = 0;
674 } 666 }
675 667
676 void ReceiveStatisticsProxy::OnRttUpdate(int64_t avg_rtt_ms, 668 void ReceiveStatisticsProxy::OnRttUpdate(int64_t avg_rtt_ms,
677 int64_t max_rtt_ms) { 669 int64_t max_rtt_ms) {
678 rtc::CritScope lock(&crit_); 670 rtc::CritScope lock(&crit_);
679 avg_rtt_ms_ = avg_rtt_ms; 671 avg_rtt_ms_ = avg_rtt_ms;
680 } 672 }
681 673
682 } // namespace webrtc 674 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | webrtc/video/receive_statistics_proxy_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698