Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 3001363002: Fix a bug in the SDP parser in AppRTCMobile. (Closed)

Created:
3 years, 4 months ago by kthelgason
Modified:
3 years, 3 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix a bug in the SDP parser in AppRTCMobile. It would leave a trailing carriage return character in the payload list, causing the preferred codec to appear twice if it was at the back of the list originally. This causes problems down the line and results in that codec not being negotiated successfully. BUG=webrtc:8129 Review-Url: https://codereview.webrtc.org/3001363002 Cr-Commit-Position: refs/heads/master@{#19552} Committed: https://chromium.googlesource.com/external/webrtc/+/6644c8b7337abcf4bb91d8658a056c9bce0f8dfe

Patch Set 1 #

Patch Set 2 : Update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M webrtc/examples/objc/AppRTCMobile/ARDSDPUtils.m View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/objc/AppRTCMobile/tests/ARDSDPUtils_xctest.mm View 1 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
kthelgason
PTAL
3 years, 4 months ago (2017-08-22 12:15:06 UTC) #2
magjed_webrtc
lgtm :P
3 years, 4 months ago (2017-08-24 09:02:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3001363002/1
3 years, 4 months ago (2017-08-24 10:50:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/builds/7257)
3 years, 4 months ago (2017-08-24 11:34:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3001363002/20001
3 years, 3 months ago (2017-08-28 07:22:27 UTC) #12
commit-bot: I haz the power
3 years, 3 months ago (2017-08-28 07:48:29 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/6644c8b7337abcf4bb91d8658...

Powered by Google App Engine
This is Rietveld 408576698