Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: webrtc/examples/objc/AppRTCMobile/ARDSDPUtils.m

Issue 3001363002: Fix a bug in the SDP parser in AppRTCMobile. (Closed)
Patch Set: Update tests Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/examples/objc/AppRTCMobile/tests/ARDSDPUtils_xctest.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2015 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #import "ARDSDPUtils.h" 11 #import "ARDSDPUtils.h"
12 12
13 #import "WebRTC/RTCLogging.h" 13 #import "WebRTC/RTCLogging.h"
14 #import "WebRTC/RTCSessionDescription.h" 14 #import "WebRTC/RTCSessionDescription.h"
15 15
16 @implementation ARDSDPUtils 16 @implementation ARDSDPUtils
17 17
18 + (RTCSessionDescription *) 18 + (RTCSessionDescription *)
19 descriptionForDescription:(RTCSessionDescription *)description 19 descriptionForDescription:(RTCSessionDescription *)description
20 preferredVideoCodec:(NSString *)codec { 20 preferredVideoCodec:(NSString *)codec {
21 NSString *sdpString = description.sdp; 21 NSString *sdpString = description.sdp;
22 NSString *lineSeparator = @"\n"; 22 NSString *lineSeparator = @"\r\n";
23 NSString *mLineSeparator = @" "; 23 NSString *mLineSeparator = @" ";
24 // Copied from PeerConnectionClient.java. 24 // Copied from PeerConnectionClient.java.
25 // TODO(tkchin): Move this to a shared C++ file. 25 // TODO(tkchin): Move this to a shared C++ file.
26 NSMutableArray *lines = 26 NSMutableArray *lines =
27 [NSMutableArray arrayWithArray: 27 [NSMutableArray arrayWithArray:
28 [sdpString componentsSeparatedByString:lineSeparator]]; 28 [sdpString componentsSeparatedByString:lineSeparator]];
29 // Find the line starting with "m=video". 29 // Find the line starting with "m=video".
30 NSInteger mLineIndex = -1; 30 NSInteger mLineIndex = -1;
31 for (NSInteger i = 0; i < lines.count; ++i) { 31 for (NSInteger i = 0; i < lines.count; ++i) {
32 if ([lines[i] hasPrefix:@"m=video"]) { 32 if ([lines[i] hasPrefix:@"m=video"]) {
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 NSString *newMLine = [newMLineParts componentsJoinedByString:mLineSeparator]; 89 NSString *newMLine = [newMLineParts componentsJoinedByString:mLineSeparator];
90 [lines replaceObjectAtIndex:mLineIndex 90 [lines replaceObjectAtIndex:mLineIndex
91 withObject:newMLine]; 91 withObject:newMLine];
92 92
93 NSString *mangledSdpString = [lines componentsJoinedByString:lineSeparator]; 93 NSString *mangledSdpString = [lines componentsJoinedByString:lineSeparator];
94 return [[RTCSessionDescription alloc] initWithType:description.type 94 return [[RTCSessionDescription alloc] initWithType:description.type
95 sdp:mangledSdpString]; 95 sdp:mangledSdpString];
96 } 96 }
97 97
98 @end 98 @end
OLDNEW
« no previous file with comments | « no previous file | webrtc/examples/objc/AppRTCMobile/tests/ARDSDPUtils_xctest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698