Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: webrtc/examples/objc/AppRTCMobile/tests/ARDSDPUtils_xctest.mm

Issue 3001363002: Fix a bug in the SDP parser in AppRTCMobile. (Closed)
Patch Set: Update tests Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/examples/objc/AppRTCMobile/ARDSDPUtils.m ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/examples/objc/AppRTCMobile/tests/ARDSDPUtils_xctest.mm
diff --git a/webrtc/examples/objc/AppRTCMobile/tests/ARDSDPUtils_xctest.mm b/webrtc/examples/objc/AppRTCMobile/tests/ARDSDPUtils_xctest.mm
index b58048f0ca59f4c526810500c8cffad0f954783f..b94f4047418fa7c2d15ee45c962004a12e84ebdf 100644
--- a/webrtc/examples/objc/AppRTCMobile/tests/ARDSDPUtils_xctest.mm
+++ b/webrtc/examples/objc/AppRTCMobile/tests/ARDSDPUtils_xctest.mm
@@ -21,31 +21,31 @@
@implementation ARDSDPUtilsTest
- (void)testPreferVideoCodecH264 {
- NSString *sdp = @("m=video 9 RTP/SAVPF 100 116 117 96 120 97\n"
- "a=rtpmap:120 H264/90000\n"
- "a=rtpmap:97 H264/90000\n");
- NSString *expectedSdp = @("m=video 9 RTP/SAVPF 120 97 100 116 117 96\n"
- "a=rtpmap:120 H264/90000\n"
- "a=rtpmap:97 H264/90000\n");
+ NSString *sdp = @("m=video 9 RTP/SAVPF 100 116 117 96 120 97\r\n"
+ "a=rtpmap:120 H264/90000\r\n"
+ "a=rtpmap:97 H264/90000\r\n");
+ NSString *expectedSdp = @("m=video 9 RTP/SAVPF 120 97 100 116 117 96\r\n"
+ "a=rtpmap:120 H264/90000\r\n"
+ "a=rtpmap:97 H264/90000\r\n");
[self preferVideoCodec:@"H264" sdp:sdp expected:expectedSdp];
}
- (void)testPreferVideoCodecVP8 {
- NSString *sdp = @("m=video 9 RTP/SAVPF 100 116 117 96 120 97\n"
- "a=rtpmap:116 VP8/90000\n");
- NSString *expectedSdp = @("m=video 9 RTP/SAVPF 116 100 117 96 120 97\n"
- "a=rtpmap:116 VP8/90000\n");
+ NSString *sdp = @("m=video 9 RTP/SAVPF 100 116 117 96 120 97\r\n"
+ "a=rtpmap:116 VP8/90000\r\n");
+ NSString *expectedSdp = @("m=video 9 RTP/SAVPF 116 100 117 96 120 97\r\n"
+ "a=rtpmap:116 VP8/90000\r\n");
[self preferVideoCodec:@"VP8" sdp:sdp expected:expectedSdp];
}
- (void)testNoMLine {
- NSString *sdp = @("a=rtpmap:116 VP8/90000\n");
+ NSString *sdp = @("a=rtpmap:116 VP8/90000\r\n");
[self preferVideoCodec:@"VP8" sdp:sdp expected:sdp];
}
- (void)testMissingCodec {
- NSString *sdp = @("m=video 9 RTP/SAVPF 100 116 117 96 120 97\n"
- "a=rtpmap:116 VP8/90000\n");
+ NSString *sdp = @("m=video 9 RTP/SAVPF 100 116 117 96 120 97\r\n"
+ "a=rtpmap:116 VP8/90000\r\n");
[self preferVideoCodec:@"foo" sdp:sdp expected:sdp];
}
« no previous file with comments | « webrtc/examples/objc/AppRTCMobile/ARDSDPUtils.m ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698