Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2997423002: Reland of Modify profiles for H264 encode SW fallback (Closed)

Created:
3 years, 3 months ago by emircan
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Modify profiles for H264 encode SW fallback (patchset #1 id:1 of https://codereview.webrtc.org/2995373002/ ) Reason for revert: Fix and reland. Original issue's description: > Revert of Modify profiles for H264 encode SW fallback (patchset #2 id:20001 of https://codereview.webrtc.org/2997913003/ ) > > Reason for revert: > Breaks the internal bots. > Root cause: The "public_deps" is defined behind an "if" condition which may not be true. > > Original issue's description: > > Modify profiles for H264 encode SW fallback > > > > We have only Constrained Baseline profile available in SW encoder impl > > so modify the profile to that in case of a fallback > > > > BUG=chromium:735959 > > > > Review-Url: https://codereview.webrtc.org/2997913003 > > Cr-Commit-Position: refs/heads/master@{#19436} > > Committed: https://chromium.googlesource.com/external/webrtc/+/1fd66656b3754c22a43f4eded57e022916bb6064 > > TBR=magjed@webrtc.org,emircan@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:735959 > > Review-Url: https://codereview.webrtc.org/2995373002 > Cr-Commit-Position: refs/heads/master@{#19438} > Committed: https://chromium.googlesource.com/external/webrtc/+/296b64eb25949d84d9cb85fce02e7ba05be9d419 TBR=magjed@webrtc.org,zhihuang@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:735959 Review-Url: https://codereview.webrtc.org/2997423002 Cr-Commit-Position: refs/heads/master@{#19476} Committed: https://chromium.googlesource.com/external/webrtc/+/82fac89381b6981f3f9d83ce38100330c700433d

Patch Set 1 #

Patch Set 2 : Fix gn issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M webrtc/media/BUILD.gn View 1 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/media/engine/videoencodersoftwarefallbackwrapper.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc View 1 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
emircan
Created Reland of Modify profiles for H264 encode SW fallback
3 years, 3 months ago (2017-08-23 17:47:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997423002/1
3 years, 3 months ago (2017-08-23 17:48:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997423002/80001
3 years, 3 months ago (2017-08-23 21:17:29 UTC) #10
commit-bot: I haz the power
3 years, 3 months ago (2017-08-23 21:19:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/82fac89381b6981f3f9d83ce3...

Powered by Google App Engine
This is Rietveld 408576698