Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2995373002: Revert of Modify profiles for H264 encode SW fallback (Closed)

Created:
3 years, 4 months ago by Zhi Huang
Modified:
3 years, 4 months ago
Reviewers:
magjed_webrtc, emircan
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Modify profiles for H264 encode SW fallback (patchset #2 id:20001 of https://codereview.webrtc.org/2997913003/ ) Reason for revert: Breaks the internal bots. Root cause: The "public_deps" is defined behind an "if" condition which may not be true. Original issue's description: > Modify profiles for H264 encode SW fallback > > We have only Constrained Baseline profile available in SW encoder impl > so modify the profile to that in case of a fallback > > BUG=chromium:735959 > > Review-Url: https://codereview.webrtc.org/2997913003 > Cr-Commit-Position: refs/heads/master@{#19436} > Committed: https://chromium.googlesource.com/external/webrtc/+/1fd66656b3754c22a43f4eded57e022916bb6064 TBR=magjed@webrtc.org,emircan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:735959 Review-Url: https://codereview.webrtc.org/2995373002 Cr-Commit-Position: refs/heads/master@{#19438} Committed: https://chromium.googlesource.com/external/webrtc/+/296b64eb25949d84d9cb85fce02e7ba05be9d419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M webrtc/media/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/media/engine/videoencodersoftwarefallbackwrapper.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc View 3 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Zhi Huang
Created Revert of Modify profiles for H264 encode SW fallback
3 years, 4 months ago (2017-08-22 00:52:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2995373002/1
3 years, 4 months ago (2017-08-22 00:52:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/296b64eb25949d84d9cb85fce02e7ba05be9d419
3 years, 4 months ago (2017-08-22 00:52:49 UTC) #6
emircan
3 years, 4 months ago (2017-08-23 17:47:56 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2997423002/ by emircan@chromium.org.

The reason for reverting is: Fix and reland..

Powered by Google App Engine
This is Rietveld 408576698