Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2997913003: Modify profiles for H264 encode SW fallback (Closed)

Created:
3 years, 4 months ago by emircan
Modified:
3 years, 4 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Modify profiles for H264 encode SW fallback We have only Constrained Baseline profile available in SW encoder impl so modify the profile to that in case of a fallback BUG=chromium:735959 Review-Url: https://codereview.webrtc.org/2997913003 Cr-Commit-Position: refs/heads/master@{#19436} Committed: https://chromium.googlesource.com/external/webrtc/+/1fd66656b3754c22a43f4eded57e022916bb6064

Patch Set 1 #

Patch Set 2 : Fix gn deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M webrtc/media/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/media/engine/videoencodersoftwarefallbackwrapper.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc View 1 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
emircan
PTAL.
3 years, 4 months ago (2017-08-16 23:56:01 UTC) #4
magjed_webrtc
lgtm
3 years, 4 months ago (2017-08-21 16:01:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2997913003/20001
3 years, 4 months ago (2017-08-22 00:27:58 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/1fd66656b3754c22a43f4eded57e022916bb6064
3 years, 4 months ago (2017-08-22 00:31:09 UTC) #18
Zhi Huang
3 years, 4 months ago (2017-08-22 00:52:25 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2995373002/ by zhihuang@webrtc.org.

The reason for reverting is: Breaks the internal bots.
Root cause: The "public_deps" is defined behind an "if" condition which may not
be true..

Powered by Google App Engine
This is Rietveld 408576698