Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2995753002:
Decoupling objc_videotoolbox from non Obj-C code (Closed)
|
Created:
3 years, 4 months ago by mbonadei Modified:
3 years, 3 months ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionThe goal of this CL is to separate Obj-C/Obj-C++ code from targets which have
also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743
for more information).
BUG=webrtc:7743
Review-Url: https://codereview.webrtc.org/2995753002
Cr-Commit-Position: refs/heads/master@{#19501}
Committed: https://chromium.googlesource.com/external/webrtc/+/c0af5ac3d0a93fb36e5e4cbd34da01c770839a2d
Patch Set 1 #Patch Set 2 : Removing comment #
Total comments: 4
Patch Set 3 : Private visibility #Patch Set 4 : Rebasing #Messages
Total messages: 19 (8 generated)
mbonadei@webrtc.org changed reviewers: + kjellander@webrtc.org
lgtm assuming trybots are happy.
https://codereview.webrtc.org/2995753002/diff/20001/webrtc/sdk/BUILD.gn File webrtc/sdk/BUILD.gn (right): https://codereview.webrtc.org/2995753002/diff/20001/webrtc/sdk/BUILD.gn#newco... webrtc/sdk/BUILD.gn:698: rtc_static_library("video_toolbox_cc") { kjellander@: Do you think it is a good name or should I change it?
https://codereview.webrtc.org/2995753002/diff/20001/webrtc/sdk/BUILD.gn File webrtc/sdk/BUILD.gn (right): https://codereview.webrtc.org/2995753002/diff/20001/webrtc/sdk/BUILD.gn#newco... webrtc/sdk/BUILD.gn:698: rtc_static_library("video_toolbox_cc") { On 2017/08/15 15:01:52, mbonadei wrote: > kjellander@: Do you think it is a good name or should I change it? It's good. The other ones should be changed in another cl. https://codereview.webrtc.org/2995753002/diff/20001/webrtc/sdk/BUILD.gn#newco... webrtc/sdk/BUILD.gn:698: rtc_static_library("video_toolbox_cc") { Restrict visibility?
https://codereview.webrtc.org/2995753002/diff/20001/webrtc/sdk/BUILD.gn File webrtc/sdk/BUILD.gn (right): https://codereview.webrtc.org/2995753002/diff/20001/webrtc/sdk/BUILD.gn#newco... webrtc/sdk/BUILD.gn:698: rtc_static_library("video_toolbox_cc") { On 2017/08/15 16:16:24, kjellander_webrtc wrote: > Restrict visibility? Done, good catch!
Description was changed from ========== Decoupling objc_videotoolbox from non Obj-C code BUG=webrtc:7743 ========== to ========== The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 ==========
The CQ bit was checked by mbonadei@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from kjellander@webrtc.org Link to the patchset: https://codereview.webrtc.org/2995753002/#ps60001 (title: "Rebasing")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_api_framework on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...)
On 2017/08/24 15:18:54, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > ios_api_framework on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/ios_api_framework/build...) This wasn't this CLs fault (https://bugs.chromium.org/p/chromium/issues/detail?id=758655). I'll submit it again.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1503602442630060,
"parent_rev": "72ba795e298fded0650d24fc698fe19d50df1b73", "commit_rev":
"c0af5ac3d0a93fb36e5e4cbd34da01c770839a2d"}
Message was sent while issue was closed.
Description was changed from ========== The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 ========== to ========== The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id=7743 for more information). BUG=webrtc:7743 Review-Url: https://codereview.webrtc.org/2995753002 Cr-Commit-Position: refs/heads/master@{#19501} Committed: https://chromium.googlesource.com/external/webrtc/+/c0af5ac3d0a93fb36e5e4cbd3... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/external/webrtc/+/c0af5ac3d0a93fb36e5e4cbd3...
Message was sent while issue was closed.
> This wasn't this CLs fault > (https://bugs.chromium.org/p/chromium/issues/detail?id=758655). I'll submit it > again. Thanks for submitting this! |
