Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: webrtc/sdk/BUILD.gn

Issue 2995753002: Decoupling objc_videotoolbox from non Obj-C code (Closed)
Patch Set: Rebasing Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/BUILD.gn
diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
index c9ecf6750b27caea16a2e9296207b6d2402ea058..2bbc785448902ae4515e93e4dfa190be2eafb556 100644
--- a/webrtc/sdk/BUILD.gn
+++ b/webrtc/sdk/BUILD.gn
@@ -706,14 +706,31 @@ if (is_ios || is_mac) {
libs = [ "CoreVideo.framework" ]
}
- rtc_static_library("videotoolbox_objc") {
+ rtc_static_library("video_toolbox_cc") {
+ visibility = [ ":*" ]
sources = [
- "objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm",
- "objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm",
"objc/Framework/Classes/VideoToolbox/helpers.cc",
"objc/Framework/Classes/VideoToolbox/helpers.h",
"objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc",
"objc/Framework/Classes/VideoToolbox/nalu_rewriter.h",
+ ]
+ deps = [
+ "../common_video",
+ "../modules:module_api",
+ "../modules/video_coding:webrtc_h264",
+ "../rtc_base:rtc_base_approved",
+ ]
+ if (!build_with_chromium && is_clang) {
+ # Suppress warnings from the Chromium Clang plugin
+ # (bugs.webrtc.org/163).
+ suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+ }
+ }
+
+ rtc_static_library("videotoolbox_objc") {
+ sources = [
+ "objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm",
+ "objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm",
"objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.h",
"objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm",
"objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.h",
@@ -726,6 +743,7 @@ if (is_ios || is_mac) {
deps = [
":common_objc",
":video_objc",
+ ":video_toolbox_cc",
":videotracksource_objc",
"../api/video_codecs:video_codecs_api",
"../common_video",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698