Decoupling objc_videotoolbox from non Obj-C code

webrtc/sdk/BUILD.gn

 # Copyright 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../webrtc.gni")
 if (is_ios) {
@@ skipping 677 matching lines @@
 
       if (!build_with_chromium && is_clang) {
         # Suppress warnings from the Chromium Clang plugin
         # (bugs.webrtc.org/163).
         suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
       }
 
       libs = [ "CoreVideo.framework" ]
     }
 
+    rtc_static_library("video_toolbox_cc") {

[mbonadei, 2017/08/15 15:01:52]

kjellander@: Do you think it is a good name or should I change it?

[kjellander_webrtc, 2017/08/15 16:16:24]

Restrict visibility?

[kjellander_webrtc, 2017/08/15 16:16:24]

It's good. The other ones should be changed in another cl.

[mbonadei, 2017/08/16 07:52:30]

Done, good catch!

+      sources = [
+        "objc/Framework/Classes/VideoToolbox/helpers.cc",
+        "objc/Framework/Classes/VideoToolbox/helpers.h",
+        "objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc",
+        "objc/Framework/Classes/VideoToolbox/nalu_rewriter.h",
+      ]
+      deps = [
+        "../common_video",
+        "../modules:module_api",
+        "../modules/video_coding:webrtc_h264",
+        "../rtc_base:rtc_base_approved",
+      ]
+      if (!build_with_chromium && is_clang) {
+        # Suppress warnings from the Chromium Clang plugin
+        # (bugs.webrtc.org/163).
+        suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+      }
+    }
+
     rtc_static_library("objc_videotoolbox") {
       sources = [
         "objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm",
         "objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm",
-        "objc/Framework/Classes/VideoToolbox/helpers.cc",
-        "objc/Framework/Classes/VideoToolbox/helpers.h",
-        "objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc",
-        "objc/Framework/Classes/VideoToolbox/nalu_rewriter.h",
         "objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.h",
         "objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm",
         "objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.h",
         "objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm",
         "objc/Framework/Headers/WebRTC/RTCVideoFrameBuffer.h",
       ]
 
       configs += [ "..:common_objc" ]
 
       deps = [
         ":objc_common",
         ":objc_video",
         ":objc_videotracksource",
+        ":video_toolbox_cc",
         "../api/video_codecs:video_codecs_api",
         "../common_video",
         "../media:rtc_media",
         "../media:rtc_media_base",
         "../modules:module_api",
         "../modules/video_coding:video_coding_utility",
         "../modules/video_coding:webrtc_h264",
         "../rtc_base:rtc_base_approved",
         "../system_wrappers",
       ]
@@ skipping 16 matching lines @@
         public_deps = [
           "$rtc_libyuv_dir",
         ]
       } else {
         # Need to add a directory normally exported by libyuv.
         include_dirs = [ "$rtc_libyuv_dir/include" ]
       }
     }
   }
 }