Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2995173002: Revert of Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabl… (Closed)

Created:
3 years, 4 months ago by emircan
Modified:
3 years, 4 months ago
Reviewers:
brandtr, åsapersson
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabl… (patchset #2 id:20001 of https://codereview.webrtc.org/2925253002/ ) Reason for revert: Failing WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityVp* tests. Mac #19383-19392 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Tester/builds/42197 Win8 #19383-19385 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win8%20Tester/builds/1496 Win7 #19383-19385 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester/builds/9807 Win10 #19383-19385 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/8452 Original issue's description: > Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabled. > > Error resilience is currently always enabled for VP9 which reduces quality. > > Reland of https://codereview.webrtc.org/2532053002 > > BUG=webrtc:6783 > > Review-Url: https://codereview.webrtc.org/2925253002 > Cr-Commit-Position: refs/heads/master@{#19385} > Committed: https://chromium.googlesource.com/external/webrtc/+/6b463faccbf145b54b8fb2666bfeab868256df08 TBR=brandtr@webrtc.org,asapersson@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6783 Review-Url: https://codereview.webrtc.org/2995173002 Cr-Commit-Position: refs/heads/master@{#19399} Committed: https://chromium.googlesource.com/external/webrtc/+/7b532db9ad08a86678c85b67179b3c444ee0a8b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -121 lines) Patch
M webrtc/modules/video_coding/video_codec_initializer.cc View 3 chunks +6 lines, -18 lines 0 comments Download
M webrtc/video/video_stream_encoder_unittest.cc View 10 chunks +6 lines, -103 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
emircan
Created Revert of Turn off error resilience for VP9 if no spatial or temporal layers ...
3 years, 4 months ago (2017-08-18 01:20:29 UTC) #2
emircan
3 years, 4 months ago (2017-08-18 07:01:19 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/3002933002/ by emircan@chromium.org.

The reason for reverting is: Speculative revert didn't help, see for the actual
reason https://bugs.chromium.org/p/chromium/issues/detail?id=756741..

Powered by Google App Engine
This is Rietveld 408576698