Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2532053002: Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabl… (Closed)

Created:
4 years ago by åsapersson
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabled. Error resilience is currently always enabled for VP9 which reduces quality. BUG=webrtc:6783 Committed: https://crrev.com/4eb03c76fa2320534d669fda2aabf800e7a6f579 Cr-Commit-Position: refs/heads/master@{#15390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -13 lines) Patch
M webrtc/common_types.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codec_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/video_codec_initializer.cc View 3 chunks +18 lines, -6 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 8 chunks +101 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
åsapersson
4 years ago (2016-11-28 12:01:29 UTC) #13
marpan
lgtm, for codec setting change
4 years ago (2016-11-29 21:32:00 UTC) #16
stefan-webrtc
lgtm
4 years ago (2016-11-30 13:04:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2532053002/40001
4 years ago (2016-12-02 16:39:20 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years ago (2016-12-02 16:58:04 UTC) #22
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4eb03c76fa2320534d669fda2aabf800e7a6f579 Cr-Commit-Position: refs/heads/master@{#15390}
4 years ago (2016-12-02 16:58:09 UTC) #24
åsapersson
4 years ago (2016-12-09 10:14:07 UTC) #25
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:40001) has been created in
https://codereview.webrtc.org/2554403006/ by asapersson@webrtc.org.

The reason for reverting is: Increase in encode time larger than expected..

Powered by Google App Engine
This is Rietveld 408576698