Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2554403006: Revert of Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabl… (Closed)

Created:
4 years ago by åsapersson
Modified:
4 years ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabl… (patchset #1 id:40001 of https://codereview.webrtc.org/2532053002/ ) Reason for revert: Increase in encode time larger than expected. Original issue's description: > Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabled. > > Error resilience is currently always enabled for VP9 which reduces quality. > > BUG=webrtc:6783 > > Committed: https://crrev.com/4eb03c76fa2320534d669fda2aabf800e7a6f579 > Cr-Commit-Position: refs/heads/master@{#15390} TBR=stefan@webrtc.org,marpan@webrtc.org,mflodman@webrtc.org,marpan@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6783 Committed: https://crrev.com/a90799d5fb8dcb56595c5b6708eea41f3cc8bf5e Cr-Commit-Position: refs/heads/master@{#15501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -122 lines) Patch
M webrtc/common_types.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codec_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/video_codec_initializer.cc View 3 chunks +6 lines, -18 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 8 chunks +4 lines, -101 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
åsapersson
4 years ago (2016-12-09 10:14:07 UTC) #2
Created Revert of Turn off error resilience for VP9 if no spatial or temporal
layers are configured and NACK is enabl…

Powered by Google App Engine
This is Rietveld 408576698