Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2925253002: Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabl… (Closed)

Created:
3 years, 6 months ago by åsapersson
Modified:
3 years, 4 months ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Turn off error resilience for VP9 if no spatial or temporal layers are configured and NACK is enabled. Error resilience is currently always enabled for VP9 which reduces quality. Reland of https://codereview.webrtc.org/2532053002 BUG=webrtc:6783 Review-Url: https://codereview.webrtc.org/2925253002 Cr-Commit-Position: refs/heads/master@{#19385} Committed: https://chromium.googlesource.com/external/webrtc/+/6b463faccbf145b54b8fb2666bfeab868256df08

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -12 lines) Patch
M webrtc/modules/video_coding/video_codec_initializer.cc View 1 3 chunks +18 lines, -6 lines 0 comments Download
M webrtc/video/video_stream_encoder_unittest.cc View 1 10 chunks +103 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
åsapersson
3 years, 4 months ago (2017-08-16 06:58:39 UTC) #5
brandtr
lgtm
3 years, 4 months ago (2017-08-17 10:41:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2925253002/20001
3 years, 4 months ago (2017-08-17 11:24:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/26617)
3 years, 4 months ago (2017-08-17 12:59:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2925253002/20001
3 years, 4 months ago (2017-08-17 13:01:19 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/6b463faccbf145b54b8fb2666bfeab868256df08
3 years, 4 months ago (2017-08-17 14:28:18 UTC) #17
emircan
3 years, 4 months ago (2017-08-18 01:20:28 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2995173002/ by emircan@chromium.org.

The reason for reverting is: Failing
WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityVp* tests.

Mac #19383-19392	
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Tester/builds...
Win8 #19383-19385
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win8%20Tester/build...
Win7 #19383-19385
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester/build...
Win10 #19383-19385
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/buil....

Powered by Google App Engine
This is Rietveld 408576698